The function now uses additionalDestinations passed from the interface

instead of pulling from rollout status for better responsiveness.

Addresses issue #112.

Signed-off-by: vthiruveedhi <[email protected]>

Author: vthiruveedhi

pkg/plugin/experiment.go

@@ -12,7 +12,7 @@ import (
 	gatewayApiClientset "sigs.k8s.io/gateway-api/pkg/client/clientset/versioned"
 )
 
-func HandleExperiment(ctx context.Context, clientset *kubernetes.Clientset, gatewayClient *gatewayApiClientset.Clientset, logger *logrus.Entry, rollout *v1alpha1.Rollout, httpRoute *gatewayv1.HTTPRoute) error {
+func HandleExperiment(ctx context.Context, clientset *kubernetes.Clientset, gatewayClient *gatewayApiClientset.Clientset, logger *logrus.Entry, rollout *v1alpha1.Rollout, httpRoute *gatewayv1.HTTPRoute, additionalDestinations []v1alpha1.WeightDestination) error {
 	ruleIdx := -1
 	stableService := rollout.Spec.Strategy.Canary.StableService
 	canaryService := rollout.Spec.Strategy.Canary.CanaryService
@@ -47,8 +47,8 @@ func HandleExperiment(ctx context.Context, clientset *kubernetes.Clientset, gate
 	if isExperimentActive {
 		logger.Info(fmt.Sprintf("Found active experiment %s", rollout.Status.Canary.CurrentExperiment))
 
-		if len(rollout.Status.Canary.Weights.Additional) == 0 {
-			logger.Info("No experiment services found in rollout status, skipping experiment service addition")
+		if len(additionalDestinations) == 0 {
+			logger.Info("No experiment services found in additionalDestinations, skipping experiment service addition")
 			return nil
 		}
 
@@ -60,9 +60,9 @@ func HandleExperiment(ctx context.Context, clientset *kubernetes.Clientset, gate
 			}
 		}
 
-		for _, additionalDestination := range rollout.Status.Canary.Weights.Additional {
-			serviceName := additionalDestination.ServiceName
-			weight := additionalDestination.Weight
+		for _, additionalDest := range additionalDestinations {
+			serviceName := additionalDest.ServiceName
+			weight := additionalDest.Weight
 
 			exists := false
 			for _, backendRef := range httpRoute.Spec.Rules[ruleIdx].BackendRefs {

pkg/plugin/httproute.go

@@ -17,7 +17,7 @@ const (
 	HTTPConfigMapKey = "httpManagedRoutes"
 )
 
-func (r *RpcPlugin) setHTTPRouteWeight(rollout *v1alpha1.Rollout, desiredWeight int32, gatewayAPIConfig *GatewayAPITrafficRouting) pluginTypes.RpcError {
+func (r *RpcPlugin) setHTTPRouteWeight(rollout *v1alpha1.Rollout, desiredWeight int32, additionalDestinations []v1alpha1.WeightDestination, gatewayAPIConfig *GatewayAPITrafficRouting) pluginTypes.RpcError {
 	ctx := context.TODO()
 	httpRouteClient := r.HTTPRouteClient
 	if !r.IsTest {
@@ -52,7 +52,7 @@ func (r *RpcPlugin) setHTTPRouteWeight(rollout *v1alpha1.Rollout, desiredWeight
 	for _, ref := range stableBackendRefs {
 		ref.Weight = &restWeight
 	}
-	err = HandleExperiment(ctx, r.Clientset, r.GatewayAPIClientset, r.LogCtx, rollout, httpRoute)
+	err = HandleExperiment(ctx, r.Clientset, r.GatewayAPIClientset, r.LogCtx, rollout, httpRoute, additionalDestinations)
 	if err != nil {
 		r.LogCtx.Error(err, "Failed to handle experiment services")
 	}

pkg/plugin/plugin.go

@@ -78,7 +78,7 @@ func (r *RpcPlugin) SetWeight(rollout *v1alpha1.Rollout, desiredWeight int32, ad
 	r.LogCtx.Info(fmt.Sprintf("[SetWeight] plugin %q controls HTTPRoutes: %v", PluginName, getGatewayAPIRouteNameList(gatewayAPIConfig.HTTPRoutes)))
 	rpcError := forEachGatewayAPIRoute(gatewayAPIConfig.HTTPRoutes, func(route HTTPRoute) pluginTypes.RpcError {
 		gatewayAPIConfig.HTTPRoute = route.Name
-		return r.setHTTPRouteWeight(rollout, desiredWeight, gatewayAPIConfig)
+		return r.setHTTPRouteWeight(rollout, desiredWeight, additionalDestinations, gatewayAPIConfig)
 	})
 	if rpcError.HasError() {
 		return rpcError