-
Notifications
You must be signed in to change notification settings - Fork 193
chore: React 18 upgrade #600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jwinters01
wants to merge
10
commits into
argoproj:master
Choose a base branch
from
jwinters01:react-18-upgrade
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
5f75eb6
merge from upstream
jwinters01 96e6ba0
initial upgrade
jwinters01 73ae7ab
react-router-dom upgrade
jwinters01 be0d492
remove storybook upgrade
jwinters01 e23173f
remove loader change
jwinters01 2885b72
fix enzyme tests
jwinters01 8bd8c81
update props for WaitFor
jwinters01 ff1102c
various typescript fixes
jwinters01 8a2052d
remove require
jwinters01 cf56b52
upgrade storybook
jwinters01 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,7 +30,6 @@ | |
| "react-autocomplete": "1.8.1", | ||
| "react-form": "^2.16.0", | ||
| "react-helmet": "^6.1.0", | ||
| "react-router-dom": "^4.2.2", | ||
| "react-toastify": "9.0.3", | ||
| "rxjs": "^7.8.1", | ||
| "typescript": "^4.9.5", | ||
|
|
@@ -39,11 +38,13 @@ | |
| "xterm-addon-fit": "^0.5.0" | ||
| }, | ||
| "peerDependencies": { | ||
| "@types/react": "^16.8.5", | ||
| "react": "^16.9.3", | ||
| "react-dom": "^16.9.3" | ||
| "@types/react": "^18.0.0", | ||
| "react": "^18.0.0", | ||
| "react-dom": "^18.0.0", | ||
| "react-router-dom": "^5.0.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@cfaester/enzyme-adapter-react-18": "^0.8.0", | ||
|
||
| "@babel/core": "^7.21.3", | ||
| "@storybook/addon-actions": "6.5.0-beta.1", | ||
| "@storybook/addon-controls": "6.5.0-beta.1", | ||
|
|
@@ -54,34 +55,33 @@ | |
| "@types/classnames": "^2.3.1", | ||
| "@types/deep-equal": "^1.0.1", | ||
| "@types/enzyme": "^3.10.12", | ||
| "@types/enzyme-adapter-react-16": "^1.0.6", | ||
| "@types/history": "^4.7.8", | ||
| "@types/jest": "^26.0.15", | ||
| "@types/node": "^18.15.3", | ||
| "@types/prop-types": "^15.7.5", | ||
| "@types/react": "^16.8.5", | ||
| "@types/react": "^18.0.0", | ||
| "@types/react-autocomplete": "^1.8.4", | ||
| "@types/react-dom": "^16.9.3", | ||
| "@types/react-dom": "^18.0.0", | ||
| "@types/react-form": "^2.16.1", | ||
| "@types/react-helmet": "^6.1.6", | ||
| "@types/react-router-dom": "^4.2.2", | ||
| "@types/react-router-dom": "^5.0.0", | ||
| "@types/uuid": "^9.0.3", | ||
| "@typescript-eslint/eslint-plugin": "^5.36.1", | ||
| "@typescript-eslint/parser": "^5.36.1", | ||
| "babel-loader": "^8.2.5", | ||
| "copy-webpack-plugin": "^4.3.1", | ||
| "css-loader": "^3.6.0", | ||
| "enzyme": "^3.11.0", | ||
| "enzyme-adapter-react-16": "^1.15.7", | ||
| "enzyme-to-json": "^3.6.2", | ||
| "eslint": "^8.23.0", | ||
| "eslint-plugin-react": "^7.31.1", | ||
| "glob": "^8.0.3", | ||
| "identity-obj-proxy": "^3.0.0", | ||
| "jest": "^26.6.3", | ||
| "raw-loader": "^4.0.2", | ||
| "react": "^16.9.3", | ||
| "react-dom": "^16.9.3", | ||
| "react": "^18.0.0", | ||
| "react-dom": "^18.0.0", | ||
| "react-router-dom": "^5.0.0", | ||
| "sass": "^1.55.0", | ||
| "sass-loader": "^v10.1.0", | ||
| "storybook": "6.5.0-beta.1", | ||
|
|
@@ -93,7 +93,7 @@ | |
| "yarn-deduplicate": "^6.0.2" | ||
| }, | ||
| "resolutions": { | ||
| "@types/react": "^16.8.5", | ||
| "@types/react": "^18.0.0", | ||
| "@types/node": "14.11.2" | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,7 @@ | ||
| import {configure } from 'enzyme'; | ||
| import Adapter from 'enzyme-adapter-react-16'; | ||
| import Enzyme from 'enzyme' | ||
| import Adapter from '@cfaester/enzyme-adapter-react-18' | ||
|
|
||
| configure({ adapter: new Adapter() }); | ||
| Enzyme.configure({ adapter: new Adapter() }); | ||
|
|
||
| // Configure testing environment for React 18 | ||
| (globalThis as any).IS_REACT_ACT_ENVIRONMENT = true; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to rely on the core UI's React router for routing to work after the upgrade