Skip to content

Commit dc37e52

Browse files
feat: add ability to use custom certs for email
With argoproj/argo-cd#15394 it has been possible to use custom certs from `argocd-tls-certs-cm`. This works as intended for any notification that is based on HTTP, but _not_ for emails (since the email doesn't make use of `http.Transport`). This commit fixes that by extracting out the TLS config to a separate function which can be called by the email service. The functionality which creates an email has been extracted from the library which was previously used since there's no support for setting custom TLS configs. This also means we can get rid of the `gomodules.xyz/notify` library. Signed-off-by: Blake Pettersson <[email protected]>
1 parent e3fe626 commit dc37e52

File tree

6 files changed

+164
-81
lines changed

6 files changed

+164
-81
lines changed

go.mod

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ require (
2828
github.com/spf13/cobra v1.9.1
2929
github.com/stretchr/testify v1.10.0
3030
golang.org/x/time v0.10.0
31-
gomodules.xyz/notify v0.1.1
3231
google.golang.org/api v0.223.0
32+
gopkg.in/gomail.v2 v2.0.0-20160411212932-81ebce5c23df
3333
gopkg.in/yaml.v3 v3.0.1
3434
k8s.io/api v0.32.2
3535
k8s.io/apimachinery v0.32.2
@@ -107,13 +107,11 @@ require (
107107
golang.org/x/sys v0.30.0 // indirect
108108
golang.org/x/term v0.29.0 // indirect
109109
golang.org/x/text v0.22.0 // indirect
110-
gomodules.xyz/envconfig v1.3.1-0.20190308184047-426f31af0d45 // indirect
111110
google.golang.org/genproto/googleapis/rpc v0.0.0-20250219182151-9fdb1cabc7b2 // indirect
112111
google.golang.org/grpc v1.70.0 // indirect
113112
google.golang.org/protobuf v1.36.5 // indirect
114113
gopkg.in/alexcesaro/quotedprintable.v3 v3.0.0-20150716171945-2caba252f4dc // indirect
115114
gopkg.in/evanphx/json-patch.v4 v4.12.0 // indirect
116-
gopkg.in/gomail.v2 v2.0.0-20160411212932-81ebce5c23df // indirect
117115
gopkg.in/inf.v0 v0.9.1 // indirect
118116
k8s.io/klog/v2 v2.130.1 // indirect
119117
k8s.io/kube-openapi v0.0.0-20241105132330-32ad38e42d3f // indirect

0 commit comments

Comments
 (0)