Skip to content

Commit 63a9f86

Browse files
committed
scrubbed install assessment errors
1 parent a1c475f commit 63a9f86

File tree

1 file changed

+3
-10
lines changed

1 file changed

+3
-10
lines changed

app/controllers/assessments_controller.rb

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -88,18 +88,11 @@ def new
8888
def installAssessment
8989
ass_dir = Rails.root.join("courses", @course.name)
9090
@unused_config_files = []
91-
flash[:error] = ""
9291
Dir.foreach(ass_dir) do |filename|
93-
# assessment's yaml file must exist
94-
if !File.exist?(File.join(ass_dir, filename, "#{filename}.yml"))
95-
flash[:error] += "Yml does not exist: " + filename +" - "
96-
next
97-
end
92+
next unless File.exist?(File.join(ass_dir, filename, "#{filename}.yml"))
93+
9894
# names must be only lowercase letters and digits
99-
if filename =~ /[^a-z0-9]/
100-
flash[:error] += "Name must be only lowercase letters and digits: "+filename
101-
next
102-
end
95+
next if filename =~ /[^a-z0-9]/
10396

10497
# Only list assessments that aren't installed yet
10598
assessment_exists = @course.assessments.exists?(name: filename)

0 commit comments

Comments
 (0)