Skip to content

perf_top.py: Fixes related to pexpect and ebizzy #3067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

perf_top.py: Fixes related to pexpect and ebizzy #3067

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08dec46
perf_top.py:test_top$ Added fix to eliminate pexpect and pexpect:spawn
Nov 19, 2025
86b5e50
perf_top.py:test_workload_output$ Fixing ebizzy run issue
Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 35 additions & 13 deletions perf/perf_top.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,9 @@
# Copyright: 2022 IBM
# Author: Disha Goel <[email protected]>

import sys
import time
import platform
import pexpect
import threading
import tempfile
import os
from avocado import Test
Expand All @@ -43,7 +42,7 @@ def setUp(self):
detected_distro = distro.detect()
self.distro_name = detected_distro.name

deps = ['gcc', 'make']
deps = ['gcc', 'make', 'ebizzy']
if 'Ubuntu' in self.distro_name:
deps.extend(['linux-tools-common', 'linux-tools-%s' %
platform.uname()[2]])
Expand All @@ -67,6 +66,9 @@ def setUp(self):
# Creating a temporary file
self.temp_file = tempfile.NamedTemporaryFile().name

def run_ebizzy(self):
process.run("ebizzy -S 30", ignore_status=True, shell=True)

def test_top(self):
if self.option in ["-k", "--vmlinux", "--kallsyms"]:
if self.distro_name in ['rhel', 'fedora', 'centos']:
Expand All @@ -76,20 +78,40 @@ def test_top(self):
self.option = self.option + " /boot/vmlinux-" + \
platform.uname()[2]

child = pexpect.spawn("perf top %s" % self.option, encoding='utf-8')
time.sleep(10)
child.logfile = sys.stdout
err = child.expect_exact(
['Error: ', 'perf: Segmentation fault', pexpect.TIMEOUT])
child.send('q')
exit_status = child.wait()
if exit_status != 0 or err == 0:
self.fail("Unknown option %s" % self.option)
cmd = f"perf top {self.option}"
self.log.info(f"Running command: {cmd}")

proc = process.SubProcess(cmd)
proc.start()
time.sleep(10) # let perf top run for a short while

# Try to stop gracefully (like pressing 'q')
if proc.poll() is None:
process.run(f"pkill -SIGINT -f '{cmd}'", ignore_status=True)
time.sleep(1)

proc.wait()

# Check for dmesg errors
dmesg.collect_errors_dmesg([
'WARNING: CPU:', 'Oops', 'Segfault',
'soft lockup', 'Unable to handle'
])

# Check exit code and stderr for issues
if proc.result.exit_status != 0:
self.fail(f"perf top failed with option {self.option}: "
f"{proc.result.stderr.decode('utf-8', 'ignore')}")

dmesg.collect_errors_dmesg(['WARNING: CPU:', 'Oops', 'Segfault',
'soft lockup', 'Unable to handle'])

def test_workload_output(self):
process.getoutput("perf top -a > %s " % self.temp_file, timeout=10)
workload_thread = threading.Thread(target=self.run_ebizzy)
workload_thread.start()

process.getoutput("perf top -a > %s " % self.temp_file, timeout=35)
workload_thread.join(timeout=5)
perf_top_output = genio.read_file(self.temp_file).splitlines()
flag = False
for lines in perf_top_output:
Expand Down
Loading