Commit 99e9cad
authored
Explicitly enable S3 ACLs for logging bucket (#61)
This is needed due to default behaviour changes in S3[1].
The newbehaviour breaks new deployments due to AccessControl being an ACL directive, and ACLs being disabled-by-default.
It is necessary for us to enable ACLs as currently CloudFront only supports logging to S3 buckets with ACLs enabled. Bucket policies are not an alternate option, CloudFront will refuse to deploy if the logging bucket does not support ACLs.
The OwnershipControls rule enables ACL behaviours. Note that I have
chosen to set this to "Bucket owner preferred" which is not the
default value. This seems like the more appropriate option - it allows
ACLs to continue to be enabled but makes new objects owned by the bucket
owner's account. See the docs[3] for more info.
References:
https://aws.amazon.com/blogs/aws/heads-up-amazon-s3-security-changes-are-coming-in-april-of-2023/
https://docs.aws.amazon.com/AmazonS3/latest/userguide/enable-server-access-logging.html
https://docs.aws.amazon.com/AmazonS3/latest/userguide/about-object-ownership.html1 parent 4ea9735 commit 99e9cad
2 files changed
+4
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
17 | 19 | | |
18 | 20 | | |
19 | 21 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
0 commit comments