removing security group limit of 5 from crd (#583)

Author: yash97

apis/vpcresources/v1beta1/securitygrouppolicy_types.go

@@ -30,7 +30,6 @@ type SecurityGroupPolicySpec struct {
 type GroupIds struct {
 	// Groups is the list of EC2 Security Groups Ids that need to be applied to the ENI of a Pod.
 	// +kubebuilder:validation:MinItems=1
-	// +kubebuilder:validation:MaxItems=5
 	Groups []string `json:"groupIds,omitempty"`
 }
 

config/crd/bases/vpcresources.k8s.aws_cninodes.yaml

@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.14.0
+    controller-gen.kubebuilder.io/version: v0.18.0
   name: cninodes.vpcresources.k8s.aws
 spec:
   group: vpcresources.k8s.aws

config/crd/bases/vpcresources.k8s.aws_securitygrouppolicies.yaml

@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.14.0
+    controller-gen.kubebuilder.io/version: v0.18.0
   name: securitygrouppolicies.vpcresources.k8s.aws
 spec:
   group: vpcresources.k8s.aws
@@ -105,7 +105,6 @@ spec:
                       need to be applied to the ENI of a Pod.
                     items:
                       type: string
-                    maxItems: 5
                     minItems: 1
                     type: array
                 type: object

config/rbac/role.yaml

@@ -12,19 +12,11 @@ rules:
   - create
   - patch
   - update
-- apiGroups:
-  - ""
-  resources:
-  - pods
-  verbs:
-  - get
-  - list
-  - patch
-  - watch
 - apiGroups:
   - ""
   resources:
   - nodes
+  - serviceaccounts
   verbs:
   - get
   - list
@@ -39,10 +31,11 @@ rules:
 - apiGroups:
   - ""
   resources:
-  - serviceaccounts
+  - pods
   verbs:
   - get
   - list
+  - patch
   - watch
 - apiGroups:
   - crd.k8s.amazonaws.com
@@ -80,21 +73,21 @@ metadata:
   namespace: kube-system
 rules:
 - apiGroups:
-  - apps
+  - ""
   resourceNames:
-  - vpc-resource-controller
+  - amazon-vpc-cni
   resources:
-  - deployments
+  - configmaps
   verbs:
   - get
   - list
   - watch
 - apiGroups:
-  - ""
+  - apps
   resourceNames:
-  - amazon-vpc-cni
+  - vpc-resource-controller
   resources:
-  - configmaps
+  - deployments
   verbs:
   - get
   - list

hack/toolchain.sh

@@ -11,7 +11,7 @@ main() {
 
 tools() {
     go install sigs.k8s.io/controller-runtime/tools/[email protected]
-    go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.14.0
+    go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.18.0
     go install github.com/google/ko@latest
 
     if ! echo "$PATH" | grep -q "${GOPATH:-undefined}/bin\|$HOME/go/bin"; then