fix(cli): deploy and destroy with --all option fails on apps with no top-level stacks

fix

Author: go-to-k

packages/aws-cdk/lib/cxapp/cloud-assembly.ts

@@ -119,6 +119,9 @@ export class CloudAssembly extends BaseStackAssembly {
   ): Promise<StackCollection> {
     if (topLevelStacks.length > 0) {
       return this.extendStacks(topLevelStacks, stacks, extend);
+    } else if (stacks.length > 0) {
+      // Fallback to all stacks if no top-level stacks (e.g., app including stages only in top-level assembly)
+      return this.extendStacks(stacks, stacks, extend);
     } else {
       throw new ToolkitError('No stack found in the main cloud assembly. Use "list" to print manifest');
     }

packages/aws-cdk/test/cli/cdk-toolkit.test.ts

@@ -150,6 +150,26 @@ function defaultToolkitSetup() {
   });
 }
 
+// only stacks within stages (no top-level stacks)
+async function stageOnlyToolkitSetup() {
+  const stageOnlyExecutable = await MockCloudExecutable.create({
+    stacks: [],
+    nestedAssemblies: [{
+      stacks: [MockStack.MOCK_STACK_C],
+    }],
+  });
+
+  return new CdkToolkit({
+    ioHost,
+    cloudExecutable: stageOnlyExecutable,
+    configuration: stageOnlyExecutable.configuration,
+    sdkProvider: stageOnlyExecutable.sdkProvider,
+    deployments: new FakeCloudFormation({
+      'Test-Stack-C': { Baz: 'Zinga!' },
+    }),
+  });
+}
+
 const mockSdk = new MockSdk();
 
 describe('bootstrap', () => {
@@ -284,6 +304,17 @@ describe('deploy', () => {
       });
     });
 
+    test('deploy all stacks in stage-only configuration with --all option', async () => {
+      // GIVEN
+      const toolkit = await stageOnlyToolkitSetup();
+
+      // WHEN & THEN
+      await expect(toolkit.deploy({
+        selector: { patterns: [], allTopLevel: true },
+        deploymentMethod: { method: 'change-set' },
+      })).resolves.not.toThrow();
+    });
+
     test('uses display names to reference assets', async () => {
       // GIVEN
       cloudExecutable = await MockCloudExecutable.create({
@@ -1080,14 +1111,23 @@ describe('destroy', () => {
   test('destroy correct stack', async () => {
     const toolkit = defaultToolkitSetup();
 
-    expect(() => {
-      return toolkit.destroy({
-        selector: { patterns: ['Test-Stack-A/Test-Stack-C'] },
-        exclusively: true,
-        force: true,
-        fromDeploy: true,
-      });
-    }).resolves;
+    await expect(toolkit.destroy({
+      selector: { patterns: ['Test-Stack-A/Test-Stack-C'] },
+      exclusively: true,
+      force: true,
+      fromDeploy: true,
+    })).resolves.not.toThrow();
+  });
+
+  test('destroy all stacks in stage-only configuration with --all option', async () => {
+    const toolkit = await stageOnlyToolkitSetup();
+
+    await expect(toolkit.destroy({
+      selector: { patterns: [], allTopLevel: true },
+      exclusively: true,
+      force: true,
+      fromDeploy: true,
+    })).resolves.not.toThrow();
   });
 });
 

packages/aws-cdk/test/cxapp/cloud-assembly.test.ts

@@ -17,6 +17,19 @@ test('select all top level stacks in the presence of nested assemblies', async (
   expect(x.stackIds).toContain('withouterrors');
 });
 
+test('select all stacks when only nested assemblies exist (Stage-only apps)', async () => {
+  // GIVEN
+  const cxasm = await testStageOnlyCloudAssembly();
+
+  // WHEN
+  const x = await cxasm.selectStacks({ allTopLevel: true, patterns: [] }, { defaultBehavior: DefaultSelection.AllStacks });
+
+  // THEN
+  expect(x.stackCount).toBe(2);
+  expect(x.stackIds).toContain('stack1');
+  expect(x.stackIds).toContain('stack2');
+});
+
 test('select stacks by glob pattern', async () => {
   // GIVEN
   const cxasm = await testCloudAssembly();
@@ -337,3 +350,28 @@ async function testNestedCloudAssembly({ env }: { env?: string; versionReporting
   const asm = await cloudExec.synthesize();
   return cliAssemblyWithForcedVersion(asm, '30.0.0');
 }
+
+async function testStageOnlyCloudAssembly({ env }: { env?: string; versionReporting?: boolean } = {}) {
+  const cloudExec = await MockCloudExecutable.create({
+    stacks: [], // No top-level stacks
+    nestedAssemblies: [{
+      stacks: [{
+        stackName: 'stack1',
+        displayName: 'stage1/stack1',
+        env,
+        template: { resource: 'resource1' },
+      }],
+    },
+    {
+      stacks: [{
+        stackName: 'stack2',
+        displayName: 'stage2/stack2',
+        env,
+        template: { resource: 'resource2' },
+      }],
+    }],
+  });
+
+  const asm = await cloudExec.synthesize();
+  return cliAssemblyWithForcedVersion(asm, '30.0.0');
+}