Skip to content

Commit a560d1e

Browse files
authored
fix(aws-cdk): init template imports not following best practices to use aws-cdk-lib/core (#916)
Follows CDK best practices by using specific imports from `aws-cdk-lib/core` instead of importing the entire `aws-cdk-lib` package. Affects all JavaScript and TypeScript templates across app, sample-app, and lib init types. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
1 parent 3d7b09b commit a560d1e

File tree

13 files changed

+14
-14
lines changed

13 files changed

+14
-14
lines changed

packages/aws-cdk/lib/init-templates/app/javascript/bin/%name%.template.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#!/usr/bin/env node
22

3-
const cdk = require('aws-cdk-lib');
3+
const cdk = require('aws-cdk-lib/core');
44
const { %name.PascalCased%Stack } = require('../lib/%name%-stack');
55

66
const app = new cdk.App();

packages/aws-cdk/lib/init-templates/app/javascript/lib/%name%-stack.template.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
const { Stack, Duration } = require('aws-cdk-lib');
1+
const { Stack, Duration } = require('aws-cdk-lib/core');
22
// const sqs = require('aws-cdk-lib/aws-sqs');
33

44
class %name.PascalCased%Stack extends Stack {

packages/aws-cdk/lib/init-templates/app/javascript/test/%name%.test.template.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// const cdk = require('aws-cdk-lib');
1+
// const cdk = require('aws-cdk-lib/core');
22
// const { Template } = require('aws-cdk-lib/assertions');
33
// const %name.PascalCased% = require('../lib/%name%-stack');
44

packages/aws-cdk/lib/init-templates/app/typescript/bin/%name%.template.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#!/usr/bin/env node
2-
import * as cdk from 'aws-cdk-lib';
2+
import * as cdk from 'aws-cdk-lib/core';
33
import { %name.PascalCased%Stack } from '../lib/%name%-stack';
44

55
const app = new cdk.App();
@@ -17,4 +17,4 @@ new %name.PascalCased%Stack(app, '%stackname%', {
1717
// env: { account: '123456789012', region: 'us-east-1' },
1818

1919
/* For more information, see https://docs.aws.amazon.com/cdk/latest/guide/environments.html */
20-
});
20+
});

packages/aws-cdk/lib/init-templates/app/typescript/lib/%name%-stack.template.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import * as cdk from 'aws-cdk-lib';
1+
import * as cdk from 'aws-cdk-lib/core';
22
import { Construct } from 'constructs';
33
// import * as sqs from 'aws-cdk-lib/aws-sqs';
44

packages/aws-cdk/lib/init-templates/app/typescript/test/%name%.test.template.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// import * as cdk from 'aws-cdk-lib';
1+
// import * as cdk from 'aws-cdk-lib/core';
22
// import { Template } from 'aws-cdk-lib/assertions';
33
// import * as %name.PascalCased% from '../lib/%name%-stack';
44

packages/aws-cdk/lib/init-templates/lib/typescript/test/%name%.test.template.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// import * as cdk from 'aws-cdk-lib';
1+
// import * as cdk from 'aws-cdk-lib/core';
22
// import { Template } from 'aws-cdk-lib/assertions';
33
// import * as %name.PascalCased% from '../lib/index';
44

packages/aws-cdk/lib/init-templates/sample-app/javascript/bin/%name%.template.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#!/usr/bin/env node
2-
const cdk = require('aws-cdk-lib');
2+
const cdk = require('aws-cdk-lib/core');
33
const { %name.PascalCased%Stack } = require('../lib/%name%-stack');
44

55
const app = new cdk.App();

packages/aws-cdk/lib/init-templates/sample-app/javascript/lib/%name%-stack.template.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
const cdk = require('aws-cdk-lib');
1+
const cdk = require('aws-cdk-lib/core');
22
const sns = require('aws-cdk-lib/aws-sns');
33
const subs = require('aws-cdk-lib/aws-sns-subscriptions');
44
const sqs = require('aws-cdk-lib/aws-sqs');

packages/aws-cdk/lib/init-templates/sample-app/javascript/test/%name%.test.template.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
const cdk = require('aws-cdk-lib');
1+
const cdk = require('aws-cdk-lib/core');
22
const { Match, Template } = require('aws-cdk-lib/assertions');
33
const %name.PascalCased% = require('../lib/%name%-stack');
44

0 commit comments

Comments
 (0)