Skip to content

Conversation

@xiazhvera
Copy link
Contributor

@xiazhvera xiazhvera commented Sep 30, 2025

Issue #, if available:

Description of changes:

  1. Add CI job to validate required files
  2. Remove old samples

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@xiazhvera xiazhvera changed the title [WIP]Add CI to validate required files Add CI to validate required files Oct 1, 2025

[**Return to main sample list**](../../README.md)

# NOTE: The sample is affected by Electron vulnerability: https://debricked.com/vulnerability-database/vulnerability/CVE-2023-5217. Electron support would be updated in future versions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this no longer the case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This vulnerability exists in Electron < 22. We added the warning as we only support Electron < 19 at that time. Now we have updated the electron support, it's no longer an concern.

Copy link
Contributor

@sbSteveK sbSteveK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the description of the PR to include what's being done in this PR

@xiazhvera xiazhvera merged commit b7d9121 into main Oct 30, 2025
16 checks passed
@xiazhvera xiazhvera deleted the file_validation branch October 30, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants