Skip to content

Commit 1273ff3

Browse files
kuhekuhe
authored
fix(clients): allow empty string field values for headers (#6511)
* fix(clients): serialize empty non-null headers * chore: update smithy hash * chore: package version updates * chore: update protocol tests
1 parent f796530 commit 1273ff3

File tree

677 files changed

+3383
-5549
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

677 files changed

+3383
-5549
lines changed

‎clients/client-accessanalyzer/package.json‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,26 +34,26 @@
3434
"@aws-sdk/util-user-agent-browser": "*",
3535
"@aws-sdk/util-user-agent-node": "*",
3636
"@smithy/config-resolver": "^3.0.8",
37-
"@smithy/core": "^2.4.3",
38-
"@smithy/fetch-http-handler": "^3.2.7",
37+
"@smithy/core": "^2.4.6",
38+
"@smithy/fetch-http-handler": "^3.2.8",
3939
"@smithy/hash-node": "^3.0.6",
4040
"@smithy/invalid-dependency": "^3.0.6",
4141
"@smithy/middleware-content-length": "^3.0.8",
4242
"@smithy/middleware-endpoint": "^3.1.3",
43-
"@smithy/middleware-retry": "^3.0.18",
43+
"@smithy/middleware-retry": "^3.0.21",
4444
"@smithy/middleware-serde": "^3.0.6",
4545
"@smithy/middleware-stack": "^3.0.6",
4646
"@smithy/node-config-provider": "^3.1.7",
47-
"@smithy/node-http-handler": "^3.2.2",
47+
"@smithy/node-http-handler": "^3.2.3",
4848
"@smithy/protocol-http": "^4.1.3",
49-
"@smithy/smithy-client": "^3.3.2",
49+
"@smithy/smithy-client": "^3.3.5",
5050
"@smithy/types": "^3.4.2",
5151
"@smithy/url-parser": "^3.0.6",
5252
"@smithy/util-base64": "^3.0.0",
5353
"@smithy/util-body-length-browser": "^3.0.0",
5454
"@smithy/util-body-length-node": "^3.0.0",
55-
"@smithy/util-defaults-mode-browser": "^3.0.18",
56-
"@smithy/util-defaults-mode-node": "^3.0.18",
55+
"@smithy/util-defaults-mode-browser": "^3.0.21",
56+
"@smithy/util-defaults-mode-node": "^3.0.21",
5757
"@smithy/util-endpoints": "^2.1.2",
5858
"@smithy/util-middleware": "^3.0.6",
5959
"@smithy/util-retry": "^3.0.6",

‎clients/client-accessanalyzer/src/protocols/Aws_restJson1.ts‎

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -852,10 +852,7 @@ export const se_UntagResourceCommand = async (
852852
b.bp("/tags/{resourceArn}");
853853
b.p("resourceArn", () => input.resourceArn!, "{resourceArn}", false);
854854
const query: any = map({
855-
[_tK]: [
856-
__expectNonNull(input.tagKeys, `tagKeys`) != null,
857-
() => (input[_tK]! || []).map((_entry) => _entry as any),
858-
],
855+
[_tK]: [__expectNonNull(input.tagKeys, `tagKeys`) != null, () => input[_tK]! || []],
859856
});
860857
let body: any;
861858
b.m("DELETE").h(headers).q(query).b(body);
@@ -2640,13 +2637,6 @@ const deserializeMetadata = (output: __HttpResponse): __ResponseMetadata => ({
26402637
const collectBodyString = (streamBody: any, context: __SerdeContext): Promise<string> =>
26412638
collectBody(streamBody, context).then((body) => context.utf8Encoder(body));
26422639

2643-
const isSerializableHeaderValue = (value: any): boolean =>
2644-
value !== undefined &&
2645-
value !== null &&
2646-
value !== "" &&
2647-
(!Object.getOwnPropertyNames(value).includes("length") || value.length != 0) &&
2648-
(!Object.getOwnPropertyNames(value).includes("size") || value.size != 0);
2649-
26502640
const _aA = "analyzerArn";
26512641
const _cT = "clientToken";
26522642
const _iRP = "includeResourcePlaceholders";

‎clients/client-account/package.json‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,26 +34,26 @@
3434
"@aws-sdk/util-user-agent-browser": "*",
3535
"@aws-sdk/util-user-agent-node": "*",
3636
"@smithy/config-resolver": "^3.0.8",
37-
"@smithy/core": "^2.4.3",
38-
"@smithy/fetch-http-handler": "^3.2.7",
37+
"@smithy/core": "^2.4.6",
38+
"@smithy/fetch-http-handler": "^3.2.8",
3939
"@smithy/hash-node": "^3.0.6",
4040
"@smithy/invalid-dependency": "^3.0.6",
4141
"@smithy/middleware-content-length": "^3.0.8",
4242
"@smithy/middleware-endpoint": "^3.1.3",
43-
"@smithy/middleware-retry": "^3.0.18",
43+
"@smithy/middleware-retry": "^3.0.21",
4444
"@smithy/middleware-serde": "^3.0.6",
4545
"@smithy/middleware-stack": "^3.0.6",
4646
"@smithy/node-config-provider": "^3.1.7",
47-
"@smithy/node-http-handler": "^3.2.2",
47+
"@smithy/node-http-handler": "^3.2.3",
4848
"@smithy/protocol-http": "^4.1.3",
49-
"@smithy/smithy-client": "^3.3.2",
49+
"@smithy/smithy-client": "^3.3.5",
5050
"@smithy/types": "^3.4.2",
5151
"@smithy/url-parser": "^3.0.6",
5252
"@smithy/util-base64": "^3.0.0",
5353
"@smithy/util-body-length-browser": "^3.0.0",
5454
"@smithy/util-body-length-node": "^3.0.0",
55-
"@smithy/util-defaults-mode-browser": "^3.0.18",
56-
"@smithy/util-defaults-mode-node": "^3.0.18",
55+
"@smithy/util-defaults-mode-browser": "^3.0.21",
56+
"@smithy/util-defaults-mode-node": "^3.0.21",
5757
"@smithy/util-endpoints": "^2.1.2",
5858
"@smithy/util-middleware": "^3.0.6",
5959
"@smithy/util-retry": "^3.0.6",

‎clients/client-account/src/protocols/Aws_restJson1.ts‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -761,10 +761,3 @@ const deserializeMetadata = (output: __HttpResponse): __ResponseMetadata => ({
761761
// Encode Uint8Array data into string with utf-8.
762762
const collectBodyString = (streamBody: any, context: __SerdeContext): Promise<string> =>
763763
collectBody(streamBody, context).then((body) => context.utf8Encoder(body));
764-
765-
const isSerializableHeaderValue = (value: any): boolean =>
766-
value !== undefined &&
767-
value !== null &&
768-
value !== "" &&
769-
(!Object.getOwnPropertyNames(value).includes("length") || value.length != 0) &&
770-
(!Object.getOwnPropertyNames(value).includes("size") || value.size != 0);

‎clients/client-acm-pca/package.json‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,26 +34,26 @@
3434
"@aws-sdk/util-user-agent-browser": "*",
3535
"@aws-sdk/util-user-agent-node": "*",
3636
"@smithy/config-resolver": "^3.0.8",
37-
"@smithy/core": "^2.4.3",
38-
"@smithy/fetch-http-handler": "^3.2.7",
37+
"@smithy/core": "^2.4.6",
38+
"@smithy/fetch-http-handler": "^3.2.8",
3939
"@smithy/hash-node": "^3.0.6",
4040
"@smithy/invalid-dependency": "^3.0.6",
4141
"@smithy/middleware-content-length": "^3.0.8",
4242
"@smithy/middleware-endpoint": "^3.1.3",
43-
"@smithy/middleware-retry": "^3.0.18",
43+
"@smithy/middleware-retry": "^3.0.21",
4444
"@smithy/middleware-serde": "^3.0.6",
4545
"@smithy/middleware-stack": "^3.0.6",
4646
"@smithy/node-config-provider": "^3.1.7",
47-
"@smithy/node-http-handler": "^3.2.2",
47+
"@smithy/node-http-handler": "^3.2.3",
4848
"@smithy/protocol-http": "^4.1.3",
49-
"@smithy/smithy-client": "^3.3.2",
49+
"@smithy/smithy-client": "^3.3.5",
5050
"@smithy/types": "^3.4.2",
5151
"@smithy/url-parser": "^3.0.6",
5252
"@smithy/util-base64": "^3.0.0",
5353
"@smithy/util-body-length-browser": "^3.0.0",
5454
"@smithy/util-body-length-node": "^3.0.0",
55-
"@smithy/util-defaults-mode-browser": "^3.0.18",
56-
"@smithy/util-defaults-mode-node": "^3.0.18",
55+
"@smithy/util-defaults-mode-browser": "^3.0.21",
56+
"@smithy/util-defaults-mode-node": "^3.0.21",
5757
"@smithy/util-endpoints": "^2.1.2",
5858
"@smithy/util-middleware": "^3.0.6",
5959
"@smithy/util-retry": "^3.0.6",

‎clients/client-acm/package.json‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,26 +34,26 @@
3434
"@aws-sdk/util-user-agent-browser": "*",
3535
"@aws-sdk/util-user-agent-node": "*",
3636
"@smithy/config-resolver": "^3.0.8",
37-
"@smithy/core": "^2.4.3",
38-
"@smithy/fetch-http-handler": "^3.2.7",
37+
"@smithy/core": "^2.4.6",
38+
"@smithy/fetch-http-handler": "^3.2.8",
3939
"@smithy/hash-node": "^3.0.6",
4040
"@smithy/invalid-dependency": "^3.0.6",
4141
"@smithy/middleware-content-length": "^3.0.8",
4242
"@smithy/middleware-endpoint": "^3.1.3",
43-
"@smithy/middleware-retry": "^3.0.18",
43+
"@smithy/middleware-retry": "^3.0.21",
4444
"@smithy/middleware-serde": "^3.0.6",
4545
"@smithy/middleware-stack": "^3.0.6",
4646
"@smithy/node-config-provider": "^3.1.7",
47-
"@smithy/node-http-handler": "^3.2.2",
47+
"@smithy/node-http-handler": "^3.2.3",
4848
"@smithy/protocol-http": "^4.1.3",
49-
"@smithy/smithy-client": "^3.3.2",
49+
"@smithy/smithy-client": "^3.3.5",
5050
"@smithy/types": "^3.4.2",
5151
"@smithy/url-parser": "^3.0.6",
5252
"@smithy/util-base64": "^3.0.0",
5353
"@smithy/util-body-length-browser": "^3.0.0",
5454
"@smithy/util-body-length-node": "^3.0.0",
55-
"@smithy/util-defaults-mode-browser": "^3.0.18",
56-
"@smithy/util-defaults-mode-node": "^3.0.18",
55+
"@smithy/util-defaults-mode-browser": "^3.0.21",
56+
"@smithy/util-defaults-mode-node": "^3.0.21",
5757
"@smithy/util-endpoints": "^2.1.2",
5858
"@smithy/util-middleware": "^3.0.6",
5959
"@smithy/util-retry": "^3.0.6",

‎clients/client-amp/package.json‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,26 +34,26 @@
3434
"@aws-sdk/util-user-agent-browser": "*",
3535
"@aws-sdk/util-user-agent-node": "*",
3636
"@smithy/config-resolver": "^3.0.8",
37-
"@smithy/core": "^2.4.3",
38-
"@smithy/fetch-http-handler": "^3.2.7",
37+
"@smithy/core": "^2.4.6",
38+
"@smithy/fetch-http-handler": "^3.2.8",
3939
"@smithy/hash-node": "^3.0.6",
4040
"@smithy/invalid-dependency": "^3.0.6",
4141
"@smithy/middleware-content-length": "^3.0.8",
4242
"@smithy/middleware-endpoint": "^3.1.3",
43-
"@smithy/middleware-retry": "^3.0.18",
43+
"@smithy/middleware-retry": "^3.0.21",
4444
"@smithy/middleware-serde": "^3.0.6",
4545
"@smithy/middleware-stack": "^3.0.6",
4646
"@smithy/node-config-provider": "^3.1.7",
47-
"@smithy/node-http-handler": "^3.2.2",
47+
"@smithy/node-http-handler": "^3.2.3",
4848
"@smithy/protocol-http": "^4.1.3",
49-
"@smithy/smithy-client": "^3.3.2",
49+
"@smithy/smithy-client": "^3.3.5",
5050
"@smithy/types": "^3.4.2",
5151
"@smithy/url-parser": "^3.0.6",
5252
"@smithy/util-base64": "^3.0.0",
5353
"@smithy/util-body-length-browser": "^3.0.0",
5454
"@smithy/util-body-length-node": "^3.0.0",
55-
"@smithy/util-defaults-mode-browser": "^3.0.18",
56-
"@smithy/util-defaults-mode-node": "^3.0.18",
55+
"@smithy/util-defaults-mode-browser": "^3.0.21",
56+
"@smithy/util-defaults-mode-node": "^3.0.21",
5757
"@smithy/util-endpoints": "^2.1.2",
5858
"@smithy/util-middleware": "^3.0.6",
5959
"@smithy/util-retry": "^3.0.6",

‎clients/client-amp/src/protocols/Aws_restJson1.ts‎

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -608,10 +608,7 @@ export const se_UntagResourceCommand = async (
608608
b.bp("/tags/{resourceArn}");
609609
b.p("resourceArn", () => input.resourceArn!, "{resourceArn}", false);
610610
const query: any = map({
611-
[_tK]: [
612-
__expectNonNull(input.tagKeys, `tagKeys`) != null,
613-
() => (input[_tK]! || []).map((_entry) => _entry as any),
614-
],
611+
[_tK]: [__expectNonNull(input.tagKeys, `tagKeys`) != null, () => input[_tK]! || []],
615612
});
616613
let body: any;
617614
b.m("DELETE").h(headers).q(query).b(body);
@@ -1629,13 +1626,6 @@ const deserializeMetadata = (output: __HttpResponse): __ResponseMetadata => ({
16291626
const collectBodyString = (streamBody: any, context: __SerdeContext): Promise<string> =>
16301627
collectBody(streamBody, context).then((body) => context.utf8Encoder(body));
16311628

1632-
const isSerializableHeaderValue = (value: any): boolean =>
1633-
value !== undefined &&
1634-
value !== null &&
1635-
value !== "" &&
1636-
(!Object.getOwnPropertyNames(value).includes("length") || value.length != 0) &&
1637-
(!Object.getOwnPropertyNames(value).includes("size") || value.size != 0);
1638-
16391629
const _a = "alias";
16401630
const _cT = "clientToken";
16411631
const _mR = "maxResults";

‎clients/client-amplify/package.json‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,26 +34,26 @@
3434
"@aws-sdk/util-user-agent-browser": "*",
3535
"@aws-sdk/util-user-agent-node": "*",
3636
"@smithy/config-resolver": "^3.0.8",
37-
"@smithy/core": "^2.4.3",
38-
"@smithy/fetch-http-handler": "^3.2.7",
37+
"@smithy/core": "^2.4.6",
38+
"@smithy/fetch-http-handler": "^3.2.8",
3939
"@smithy/hash-node": "^3.0.6",
4040
"@smithy/invalid-dependency": "^3.0.6",
4141
"@smithy/middleware-content-length": "^3.0.8",
4242
"@smithy/middleware-endpoint": "^3.1.3",
43-
"@smithy/middleware-retry": "^3.0.18",
43+
"@smithy/middleware-retry": "^3.0.21",
4444
"@smithy/middleware-serde": "^3.0.6",
4545
"@smithy/middleware-stack": "^3.0.6",
4646
"@smithy/node-config-provider": "^3.1.7",
47-
"@smithy/node-http-handler": "^3.2.2",
47+
"@smithy/node-http-handler": "^3.2.3",
4848
"@smithy/protocol-http": "^4.1.3",
49-
"@smithy/smithy-client": "^3.3.2",
49+
"@smithy/smithy-client": "^3.3.5",
5050
"@smithy/types": "^3.4.2",
5151
"@smithy/url-parser": "^3.0.6",
5252
"@smithy/util-base64": "^3.0.0",
5353
"@smithy/util-body-length-browser": "^3.0.0",
5454
"@smithy/util-body-length-node": "^3.0.0",
55-
"@smithy/util-defaults-mode-browser": "^3.0.18",
56-
"@smithy/util-defaults-mode-node": "^3.0.18",
55+
"@smithy/util-defaults-mode-browser": "^3.0.21",
56+
"@smithy/util-defaults-mode-node": "^3.0.21",
5757
"@smithy/util-endpoints": "^2.1.2",
5858
"@smithy/util-middleware": "^3.0.6",
5959
"@smithy/util-retry": "^3.0.6",

‎clients/client-amplify/src/protocols/Aws_restJson1.ts‎

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -801,10 +801,7 @@ export const se_UntagResourceCommand = async (
801801
b.bp("/tags/{resourceArn}");
802802
b.p("resourceArn", () => input.resourceArn!, "{resourceArn}", false);
803803
const query: any = map({
804-
[_tK]: [
805-
__expectNonNull(input.tagKeys, `tagKeys`) != null,
806-
() => (input[_tK]! || []).map((_entry) => _entry as any),
807-
],
804+
[_tK]: [__expectNonNull(input.tagKeys, `tagKeys`) != null, () => input[_tK]! || []],
808805
});
809806
let body: any;
810807
b.m("DELETE").h(headers).q(query).b(body);
@@ -2207,13 +2204,6 @@ const deserializeMetadata = (output: __HttpResponse): __ResponseMetadata => ({
22072204
const collectBodyString = (streamBody: any, context: __SerdeContext): Promise<string> =>
22082205
collectBody(streamBody, context).then((body) => context.utf8Encoder(body));
22092206

2210-
const isSerializableHeaderValue = (value: any): boolean =>
2211-
value !== undefined &&
2212-
value !== null &&
2213-
value !== "" &&
2214-
(!Object.getOwnPropertyNames(value).includes("length") || value.length != 0) &&
2215-
(!Object.getOwnPropertyNames(value).includes("size") || value.size != 0);
2216-
22172207
const _eN = "environmentName";
22182208
const _mR = "maxResults";
22192209
const _nT = "nextToken";

0 commit comments

Comments
 (0)