Obsolete AWS4aSignerCRTWrapper and related APIs.

Author: teo-tsirpanis

extensions/src/AWSSDK.Extensions.CrtIntegration/CrtAWS4aSigner.cs

@@ -24,6 +24,7 @@
 using AWSSDK.Extensions.CrtIntegration;
 using System;
 using System.Collections.Generic;
+using System.ComponentModel;
 using System.Globalization;
 using System.IO;
 using System.Linq;
@@ -34,6 +35,7 @@ namespace Amazon.Extensions.CrtIntegration
     /// <summary>
     /// Asymmetric Sigv4 (SigV4a) protocol signer using the implementation provided by Aws.Crt.Auth
     /// </summary>
+    [Obsolete("Use Amazon.Runtime.Internal.Auth.AWS4aSigner instead."), EditorBrowsable(EditorBrowsableState.Never)]
     public class CrtAWS4aSigner : IAWSSigV4aProvider
     {
         /// <summary>

sdk/src/Core/Amazon.Runtime/Internal/Auth/AWS4aSignerCRTWrapper.cs

@@ -19,6 +19,7 @@
 using Amazon.Util.Internal;
 using System;
 using System.Collections.Generic;
+using System.ComponentModel;
 using System.Diagnostics.CodeAnalysis;
 using System.Globalization;
 using System.IO;
@@ -29,6 +30,7 @@ namespace Amazon.Runtime.Internal.Auth
     /// <summary>
     /// Asymmetric SigV4 signer using a the AWS Common Runtime implementation of SigV4a via AWSSDK.Extensions.CrtIntegration 
     /// </summary>
+    [Obsolete("Use AWS4aSigner instead."), EditorBrowsable(EditorBrowsableState.Never)]
     public class AWS4aSignerCRTWrapper : AbstractAWSSigner
     {
         internal const string CRT_WRAPPER_ASSEMBLY_NAME = "AWSSDK.Extensions.CrtIntegration";

sdk/src/Core/Amazon.Runtime/Pipeline/Handlers/BaseEndpointResolver.cs

@@ -162,16 +162,6 @@ private static void SetAuthenticationAndHeaders(IRequest request, Endpoint endpo
                                     }
                                 case "sigv4a":
                                     {
-                                        // If there are multiple authentication schemes but the CRT dependency is not available,
-                                        // we will proceed to check the next value in authSchemes.
-                                        if (hasMultipleSchemes)
-                                        {
-                                            if (!IsCrtDependencyAvailable())
-                                            {
-                                                continue;
-                                            }
-                                        }
-
                                         request.SignatureVersion = SignatureVersion.SigV4a;
 
                                         var signingRegions = ((List<object>)schema["signingRegionSet"]).OfType<string>().ToArray();
@@ -220,25 +210,6 @@ private static void ApplyCommonSchema(IRequest request, PropertyBag schema)
             }
         }
 
-        /// <summary>
-        /// Validates whether the CRT dependency is available by trying to create an <see cref="AWS4aSignerCRTWrapper"/> instance.
-        /// </summary>
-        /// <returns>
-        /// True if the CRT package is available at runtime, false otherwise.
-        /// </returns>
-        private static bool IsCrtDependencyAvailable()
-        {
-            try
-            {
-                var signer = new AWS4aSignerCRTWrapper();
-                return signer != null;
-            }
-            catch (AWSCommonRuntimeException)
-            {
-                return false;
-            }
-        }
-
         /// <summary>
         /// Inject host prefix into request endpoint.
         /// </summary>

sdk/src/Core/Amazon.Runtime/SharedInterfaces/IAWSSigV4aProvider.cs

@@ -16,14 +16,17 @@
 using Amazon.Runtime.Internal;
 using Amazon.Runtime.Internal.Auth;
 using Amazon.Runtime.Internal.Util;
+using System;
 using System.Collections.Generic;
+using System.ComponentModel;
 using System.IO;
 
 namespace Amazon.Runtime.SharedInterfaces
 {
     /// <summary>
     /// Interface for an asymmetric SigV4 (SigV4a) signer
     /// </summary>
+    [Obsolete("SigV4a provider is now built-in; this interface is no longer necessary to implement."), EditorBrowsable(EditorBrowsableState.Never)]
     public interface IAWSSigV4aProvider
     {
         /// <summary>

sdk/src/Core/RuntimeDependencies/GlobalRuntimeDependencyRegistry.cs

@@ -15,6 +15,8 @@
 using Amazon.Runtime.Internal;
 using Amazon.Runtime.Internal.Auth;
 using AWSSDK.Runtime.Internal.Util;
+using System;
+using System.ComponentModel;
 
 namespace Amazon.RuntimeDependencies
 {
@@ -60,10 +62,11 @@ public void RegisterChecksumProvider(object instance)
         /// GlobalRuntimeDependencyRegistry.Instance.RegisterSigV4aProvider((context) =>
         /// {
         ///     return new Amazon.Extensions.CrtIntegration.CrtAWS4aSigner(context.SigV4aCrtSignerContextData.Payload);
-        /// }
+        /// });
         /// </code>
         /// </summary>
         /// <param name="factory"></param>
+        [Obsolete("SigV4a provider is now built-in; this method is no longer necessary to call."), EditorBrowsable(EditorBrowsableState.Never)]
         public void RegisterSigV4aProvider(RuntimeDependencyFactory factory)
         {
             RegisterInstance(AWS4aSignerCRTWrapper.CRT_WRAPPER_ASSEMBLY_NAME, AWS4aSignerCRTWrapper.CRT_WRAPPER_CLASS_NAME, factory);