move tests

Author: GarrettBeatty

sdk/test/Services/S3/UnitTests/Custom/MultipartDownloadManagerTests.cs

@@ -2284,7 +2284,7 @@ public async Task HttpSemaphore_RangeStrategy_HeldThroughProcessPartAsync()
         #region Semaphore Release Error Path Tests
 
         [TestMethod]
-        public async Task StartDownloadAsync_WaitForCapacityFails_DoesNotReleaseHttpSemaphore()
+        public async Task Discovery_WaitForCapacityFails_DoesNotReleaseHttpSemaphore()
         {
             // Arrange - Test that semaphore is NOT released when it was never acquired
             var httpThrottler = new SemaphoreSlim(2, 2);
@@ -2323,8 +2323,9 @@ public async Task StartDownloadAsync_WaitForCapacityFails_DoesNotReleaseHttpSema
         }
 
 
+
         [TestMethod]
-        public async Task Discovery_WaitForCapacityFails_DoesNotReleaseHttpSemaphore()
+        public async Task StartDownloadAsync_WaitForCapacityFails_DoesNotReleaseHttpSemaphore()
         {
             // Arrange - Test that semaphore is NOT released when it was never acquired
             var httpThrottler = new SemaphoreSlim(2, 2);
@@ -2362,8 +2363,6 @@ public async Task Discovery_WaitForCapacityFails_DoesNotReleaseHttpSemaphore()
             httpThrottler.Dispose();
         }
 
-
-
         [TestMethod]
         public async Task Discovery_HttpRequestAfterCapacityFails_ReleasesHttpSemaphore()
         {
@@ -2460,53 +2459,6 @@ public async Task StartDownloadAsync_PrepareAsyncFails_ReleasesHttpSemaphore()
             httpThrottler.Dispose();
         }
 
-        [TestMethod]
-        public async Task StartDownloadAsync_Part1ProcessingFails_ReleasesHttpSemaphore()
-        {
-            // Arrange - Test that HTTP semaphore is released when Part 1 processing fails during discovery
-            var httpThrottler = new SemaphoreSlim(2, 2);
-            var initialCount = httpThrottler.CurrentCount;
-            
-            var mockDataHandler = new Mock<IPartDataHandler>();
-            
-            // WaitForCapacityAsync succeeds
-            mockDataHandler
-                .Setup(x => x.WaitForCapacityAsync(It.IsAny<CancellationToken>()))
-                .Returns(Task.CompletedTask);
-            
-            // Part 1 ProcessPartAsync FAILS (during discovery phase of StartDownloadAsync)
-            mockDataHandler
-                .Setup(x => x.ProcessPartAsync(1, It.IsAny<GetObjectResponse>(), It.IsAny<CancellationToken>()))
-                .ThrowsAsync(new InvalidOperationException("Simulated Part 1 processing failure"));
-            
-            var mockClient = MultipartDownloadTestHelpers.CreateMockS3ClientForMultipart(
-                2, 8 * 1024 * 1024, 16 * 1024 * 1024, "test-etag", usePartStrategy: true);
-            
-            var request = MultipartDownloadTestHelpers.CreateOpenStreamRequest(
-                downloadType: MultipartDownloadType.PART);
-            var config = MultipartDownloadTestHelpers.CreateBufferedDownloadConfiguration();
-            var coordinator = new MultipartDownloadManager(
-                mockClient.Object, request, config, mockDataHandler.Object, null, httpThrottler);
-
-            // Act & Assert
-            try
-            {
-                await coordinator.StartDownloadAsync(null, CancellationToken.None);
-                Assert.Fail("Expected InvalidOperationException to be thrown");
-            }
-            catch (InvalidOperationException ex)
-            {
-                Assert.AreEqual("Simulated Part 1 processing failure", ex.Message);
-            }
-
-            // Assert - HTTP semaphore should be released when Part 1 processing fails
-            Assert.AreEqual(initialCount, httpThrottler.CurrentCount, 
-                "HTTP semaphore should be released when Part 1 processing fails during discovery");
-            
-            // Cleanup
-            httpThrottler.Dispose();
-        }
-
         [TestMethod]
         public async Task StartDownloadAsync_BackgroundPartHttpFails_ReleasesHttpSemaphore()
         {
@@ -2573,6 +2525,53 @@ public async Task StartDownloadAsync_BackgroundPartHttpFails_ReleasesHttpSemapho
             httpThrottler.Dispose();
         }
 
+        [TestMethod]
+        public async Task StartDownloadAsync_Part1ProcessingFails_ReleasesHttpSemaphore()
+        {
+            // Arrange - Test that HTTP semaphore is released when Part 1 processing fails during discovery
+            var httpThrottler = new SemaphoreSlim(2, 2);
+            var initialCount = httpThrottler.CurrentCount;
+            
+            var mockDataHandler = new Mock<IPartDataHandler>();
+            
+            // WaitForCapacityAsync succeeds
+            mockDataHandler
+                .Setup(x => x.WaitForCapacityAsync(It.IsAny<CancellationToken>()))
+                .Returns(Task.CompletedTask);
+            
+            // Part 1 ProcessPartAsync FAILS (during discovery phase of StartDownloadAsync)
+            mockDataHandler
+                .Setup(x => x.ProcessPartAsync(1, It.IsAny<GetObjectResponse>(), It.IsAny<CancellationToken>()))
+                .ThrowsAsync(new InvalidOperationException("Simulated Part 1 processing failure"));
+            
+            var mockClient = MultipartDownloadTestHelpers.CreateMockS3ClientForMultipart(
+                2, 8 * 1024 * 1024, 16 * 1024 * 1024, "test-etag", usePartStrategy: true);
+            
+            var request = MultipartDownloadTestHelpers.CreateOpenStreamRequest(
+                downloadType: MultipartDownloadType.PART);
+            var config = MultipartDownloadTestHelpers.CreateBufferedDownloadConfiguration();
+            var coordinator = new MultipartDownloadManager(
+                mockClient.Object, request, config, mockDataHandler.Object, null, httpThrottler);
+
+            // Act & Assert
+            try
+            {
+                await coordinator.StartDownloadAsync(null, CancellationToken.None);
+                Assert.Fail("Expected InvalidOperationException to be thrown");
+            }
+            catch (InvalidOperationException ex)
+            {
+                Assert.AreEqual("Simulated Part 1 processing failure", ex.Message);
+            }
+
+            // Assert - HTTP semaphore should be released when Part 1 processing fails
+            Assert.AreEqual(initialCount, httpThrottler.CurrentCount, 
+                "HTTP semaphore should be released when Part 1 processing fails during discovery");
+            
+            // Cleanup
+            httpThrottler.Dispose();
+        }
+
         [TestMethod]
         public async Task StartDownloadAsync_BackgroundPartProcessingFails_ReleasesHttpSemaphore()
         {