-
Notifications
You must be signed in to change notification settings - Fork 151
Description
Security issue notifications
Problem:
We very recently implemented a s2n-quic-dc-metrics crate to provide metrics tracking for s2n-quic-dc: #2884. However, due to implementation reason, we have to use some operations that are only stable after rustc version of 1.88.0. As a result of that, s2n-quic-dc-metrics crate will use rust version 1.88.0 but the MSRV for the rest will remain at 1.84.0.
Hence, in our tests steps the CI, I have to disable tests for s2n-quic-dc-metrics crate if the rust version is running on 1.84.0: https://github.com/aws/s2n-quic/pull/2884/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR251-R252.
We need to remove that exceptions and clean up our CI yml script once the rest of s2n-quic's crates got updated to use 1.88.0 as their MSRVs.
Need By Date:
Whenever s2n-quic's MSRV got updated to 1.88.0.
Solution:
Revisit this ticket and apply clean ups.
Requirements / Acceptance Criteria:
MSRV tests should be ran on s2n-quic-dc-metrics crate.
Out of scope:
N/A