chore: refactor

Author: chesterkmr

apps/backoffice-v2/src/pages/Entity/components/Case/hooks/useDocuments/helpers.ts

@@ -1,10 +1,11 @@
 import { isCsv } from '@/common/utils/is-csv/is-csv';
 import { convertCsvToPdfBase64String } from '../../../../../../common/utils/convert-csv-to-pdf-base64-string/convert-csv-to-pdf-base64-string';
 import { IDocumentsProps } from '../../interfaces';
+import { isBase64 } from '@/common/utils/is-base64/is-base64';
 
 export const convertCsvDocumentsToPdf = (documents: IDocumentsProps['documents']) => {
   return documents?.map(document => {
-    if (isCsv(document) && document.base64) {
+    if (isCsv(document) && isBase64(document.base64 || '')) {
       return { ...document, imageUrl: convertCsvToPdfBase64String(document.base64) };
     }
 

services/workflows-service/src/document/document.service.ts

@@ -49,6 +49,8 @@ import {
 import { PrismaService } from '@/prisma/prisma.service';
 import { assertIsValidProjectIds } from '@/project/project-scope.service';
 import { HttpService } from '@nestjs/axios';
+import { isCsvMimetype } from './utils/is-csv-mimetype';
+import { fetchCsvFromUrlAndConvertToBase64 } from './utils/fetch-csv-from-url-and-convert-to-base-64';
 
 @Injectable()
 export class DocumentService {
@@ -1184,9 +1186,9 @@ export class DocumentService {
         files.map(async ({ imageUrl, file, ...fileData }) => {
           let base64: string | undefined;
 
-          if (this.isCsv(fileData) && imageUrl) {
+          if (isCsvMimetype(fileData.mimeType) && imageUrl) {
             try {
-              base64 = await this.fetchCsvFromUrlAndCovertToBase64(imageUrl);
+              base64 = await fetchCsvFromUrlAndConvertToBase64(imageUrl);
             } catch (error) {
               console.error(`Failed to fetch CSV and convert to base64 file ${file.id}:`, error);
             }
@@ -1212,23 +1214,6 @@ export class DocumentService {
     return Promise.all(formatPromises);
   }
 
-  private isCsv(file: { mimeType: string | null }) {
-    return file.mimeType === 'text/csv' || file.mimeType === 'application/csv';
-  }
-
-  private async fetchCsvFromUrlAndCovertToBase64(csvUrl: string) {
-    const response = await this.httpService.axiosRef.get(csvUrl, {
-      responseType: 'arraybuffer',
-    });
-    const buffer = response.data;
-    const base64 = Buffer.from(buffer).toString('base64');
-    const contentType = response.headers['content-type'];
-
-    const base64Result = `data:${contentType};base64,${base64}`;
-
-    return base64Result;
-  }
-
   getLatestDocumentVersions(documents: Document[]) {
     const documentsByType = documents.reduce((acc, document) => {
       const documentId = document.businessId

services/workflows-service/src/document/utils/fetch-csv-from-url-and-convert-to-base-64.ts

@@ -0,0 +1,14 @@
+import axios from 'axios';
+
+export const fetchCsvFromUrlAndConvertToBase64 = async (csvUrl: string) => {
+  const response = await axios.get(csvUrl, {
+    responseType: 'arraybuffer',
+  });
+  const buffer = response.data;
+  const base64 = Buffer.from(buffer).toString('base64');
+  const contentType = response.headers['content-type'];
+
+  const base64Result = `data:${contentType};base64,${base64}`;
+
+  return base64Result;
+};

services/workflows-service/src/document/utils/is-csv-mimetype.ts

@@ -0,0 +1,2 @@
+export const isCsvMimetype = (mimeType: string | null) =>
+  mimeType === 'text/csv' || mimeType === 'application/csv';