Revert "feat: use run time variables in dist (#2476)"

alonp99 · alonp99 · commit b6a48f3ad3cb · 2025-01-28T15:46:43.000+02:00
This reverts commit f19f65c.
diff --git a/apps/workflows-dashboard/Dockerfile b/apps/workflows-dashboard/Dockerfile
@@ -19,18 +19,10 @@ CMD ["npm", "run", "dev", "--host"]
 
 FROM nginx:stable-alpine as prod
 
-WORKDIR /app
-
 COPY --from=dev /app/dist /usr/share/nginx/html
 
-COPY --from=dev /app/entrypoint.sh /app/entrypoint.sh
-
 COPY example.nginx.conf /etc/nginx/conf.d/default.conf
 
-RUN chmod a+x /app/entrypoint.sh;
-
 EXPOSE 80
 
-ENTRYPOINT [ "/app/entrypoint.sh" ]
-
 CMD ["nginx", "-g", "daemon off;"]
diff --git a/apps/workflows-dashboard/entrypoint.sh b/apps/workflows-dashboard/entrypoint.sh
diff --git a/apps/workflows-dashboard/global.d.ts b/apps/workflows-dashboard/global.d.ts
diff --git a/apps/workflows-dashboard/index.html b/apps/workflows-dashboard/index.html
@@ -6,7 +6,6 @@
     <link rel="icon" type="image/png" sizes="16x16" href="/public/favicon-16x16.png" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>Workflow Dashboard</title>
-    <script type="text/javascript" src="/config.js"></script>
   </head>
   <body>
     <div id="root"></div>
diff --git a/apps/workflows-dashboard/package.json b/apps/workflows-dashboard/package.json
@@ -7,8 +7,8 @@
     "spellcheck": "cspell \"*\"",
     "dev": "vite --host",
     "start": "vite",
+    "build": "tsc && vite build",
     "prod:next": "vite build && vite --host",
-    "build": "rm -rf dist && tsc && vite build",
     "lint": "eslint . --fix",
     "format": "prettier --write .",
     "format:check": "prettier --check .",
diff --git a/apps/workflows-dashboard/public/config.js b/apps/workflows-dashboard/public/config.js
diff --git a/apps/workflows-dashboard/src/lib/request/request.ts b/apps/workflows-dashboard/src/lib/request/request.ts
@@ -1,8 +1,7 @@
 import axios from 'axios';
 
 export const request = axios.create({
-  //@ts-ignore
-  baseURL: globalThis.env.VITE_API_URL,
+  baseURL: import.meta.env.VITE_API_URL,
   withCredentials: true,
 });
 
diff --git a/deploy/.env b/deploy/.env
@@ -30,7 +30,3 @@ BACKOFFICE_PORT=5137
 HEADLESS_SVC_PORT=5173
 HASHING_KEY_SECRET_BASE64=JDJiJDEwJFRYNjhmQi5JMlRCWHN0aGowakFHSi4=
 SECRETS_MANAGER_PROVIDER=in-memory
-VITE_DOMAIN=""
-VITE_ENVIRONMENT_NAME=""
-VITE_IMAGE_LOGO_URL=""
-MODE=""
diff --git a/deploy/docker-compose-build.yml b/deploy/docker-compose-build.yml
@@ -78,11 +78,6 @@ services:
       - ${WORKFLOW_DASHBOARD_PORT}:80
     depends_on:
       - ballerine-workflow-service
-    environment:
-      VITE_DOMAIN: ${VITE_DOMAIN}
-      VITE_ENVIRONMENT_NAME: ${VITE_ENVIRONMENT_NAME}
-      VITE_IMAGE_LOGO_URL: ${VITE_IMAGE_LOGO_URL}
-      MODE: ${MODE}
     restart: on-failure
   ballerine-postgres:
     container_name: postgres
