feat: added safe filter with warnings for missing entity ids

Author: chesterkmr

apps/backoffice-v2/src/common/utils/safe-entity-id-filter/safe-entity-id-filter.ts

@@ -0,0 +1,14 @@
+export const safeEntityIdFilter = <T>(list: Array<T>, filter: (item: T) => boolean) => {
+  return list.filter(item => {
+    const result = filter(item);
+    const isMissing = !result;
+
+    if (isMissing) {
+      console.warn(
+        `Missing entity id of entity: ${JSON.stringify(item)}. Entity id will be skipped.`,
+      );
+    }
+
+    return result;
+  });
+};

apps/backoffice-v2/src/lib/blocks/hooks/useBusinessDocuments/useBusinessDocuments.ts

@@ -1,3 +1,4 @@
+import { safeEntityIdFilter } from '@/common/utils/safe-entity-id-filter/safe-entity-id-filter';
 import { useWorkflowDocumentsAdapter } from '@/domains/documents/hooks/adapters/useWorkflowDocumentsAdapter/useWorkflowDocumentsAdapter';
 import { TWorkflowById } from '@/domains/workflows/fetchers';
 import { TDocument } from '@ballerine/common';
@@ -7,7 +8,9 @@ export const useBusinessDocuments = (workflow: TWorkflowById) => {
   const entityIds = useMemo(
     () =>
       workflow?.context?.entity?.ballerineEntityId
-        ? [workflow?.context?.entity?.ballerineEntityId]
+        ? safeEntityIdFilter([workflow?.context?.entity], entity =>
+            Boolean(entity.ballerineEntityId),
+          ).map(entity => entity.ballerineEntityId)
         : [],
     [workflow],
   );

apps/backoffice-v2/src/lib/blocks/hooks/useDirectorsDocuments/helpers/get-directors-ids-from-workflow.ts

@@ -1,5 +1,8 @@
+import { safeEntityIdFilter } from '@/common/utils/safe-entity-id-filter/safe-entity-id-filter';
 import { TWorkflowById } from '@/domains/workflows/fetchers';
 
 export const getDirectorsIdsFromWorkflow = (workflow: TWorkflowById) =>
-  workflow.endUsers?.filter(endUser => endUser.variant === 'director').map(endUser => endUser.id) ||
-  [];
+  safeEntityIdFilter(
+    workflow.endUsers?.filter(endUser => endUser.variant === 'director') || [],
+    endUser => Boolean(endUser.id),
+  ).map(endUser => endUser.id);

apps/backoffice-v2/src/lib/blocks/hooks/useUbosDocuments/helpers/get-ubos-entity-ids-from-workflow.ts

@@ -1,7 +1,9 @@
+import { safeEntityIdFilter } from '@/common/utils/safe-entity-id-filter/safe-entity-id-filter';
 import { TWorkflowById } from '@/domains/workflows/fetchers';
 
 export const getUbosEntityIdsFromWorkflow = (workflow: TWorkflowById) => {
-  return (
-    workflow.endUsers?.filter(endUser => endUser.variant === 'ubo').map(endUser => endUser.id) || []
-  );
+  return safeEntityIdFilter(
+    workflow.endUsers?.filter(endUser => endUser.variant === 'ubo') || [],
+    endUser => Boolean(endUser.id),
+  ).map(endUser => endUser.id);
 };