Dev to sb #3301
Merged
Dev to sb #3301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * fix(bal-4087): magic links not working when url leads to 404 page * fix(bal-4087): incorrect url --------- Co-authored-by: Alon Peretz <[email protected]>
…3290) * fix: reworked document update & fixed not persisted comment & reason * chore: refactor
…hecks (#3289) * feat(rule-engine): introduce AML_CHECK_V2 operator for enhanced AML checks - Add AML_CHECK_V2 operator to validate adverse media, PEP, sanctions, and fitness probity - Implement rule evaluation to return results based on the presence of AML hits - Update TypeScript types and schemas to support new operator logic and helpers * refactor(aml-v2-check): improve null handling for ubos and directors IDs - Replace implicit null checks with optional chaining and default values - Filter out any falsy IDs before fetching end users - Enhance code readability and maintainability by streamlining mapping operations * feat(tests): add comprehensive unit tests for AML v2 rules - Introduce new unit tests for AML v2, verifying multiple rule outcomes - Implement helper function for fetching user details in test scenarios - Refactor existing company sanctions test cases to utilize helper function * refactor(tests): consolidate helper functions into data-helper module - Move getEndUserById function to data-helper for better organization - Remove redundant helper definitions in individual test files - Ensure that all test modules now import the shared helpers from data-helper * refactor(types): make helpers property optional in WorkflowOptions and WorkflowRunnerArgs - Update WorkflowOptions and WorkflowRunnerArgs interfaces to allow helpers to be optional - Adjust related types for consistency and flexibility in workflow handling * fix(aml-check): improve end user validation logic and error handling - Refactor end user ID collection to handle empty cases correctly - Throw validation error with detailed message if no end users found - Adjust validation condition for more explicit failure handling --------- Co-authored-by: Alon Peretz <[email protected]>
- Bump versions for multiple packages to the latest patch versions - Update dependencies across various modules for improved stability and features
* feat: included credentials in axios instance & updated tests * feat: added default null for access token * chore: bump
* chore: initial & conencted modules & resolved circular deps * feat: updated context schema * feat: added workflow-collection-flow controller get/put * feat: added collection-flow domain, reworked collection flow state updating logic * chore: bump * feat: added collection flow state update during sync & final submission * fix: fixed schemas * feat: fixed dto's * chore: refactor * fix: lint * chore: refactor * feat: added sync of collection flow state if computation result is different * fix: fixed inconsistency between state context and workflow * chore: format * fix: fixed exception * fix: fixed tests * chore: refactored error handling * feat: updated dto * fix: removed reduntant type
…ons in workflows (#3294) Co-authored-by: Dhruv Bundheliya <[email protected]>
* fix: fixed bug where errors thrown from tasks wasnt handled * chore: kyb & ui bump * fix: updated log type
* feat: moved file extensions to common & updated ui & bump * chore: bump
…ry date (#3274) Co-authored-by: Tomer Shvadron <[email protected]>
|
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.