Skip to content

Commit 4390cba

Browse files
removed prepared statement parameter for table name due to incompatibilities with PDO.
1 parent 03b24ee commit 4390cba

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

lib/DocumentAuthentication/Plugin.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -66,11 +66,12 @@ public static function uninstall()
6666
{
6767
$database = Pimcore_Resource_Mysql::getConnection();
6868

69-
$sqlQuery = "DELETE FROM ? WHERE name = ?";
69+
$sqlQuery = "DELETE FROM " . self::DB_TABLE_PRE_PROPERTIES . " WHERE name = ?";
70+
$database->query($sqlQuery, array(self::DOC_PROPERTY_DOCUMENT_AUTHENTICATION_ENABLED));
7071

71-
$database->query($sqlQuery, array(self::DB_TABLE_PRE_PROPERTIES, self::DOC_PROPERTY_DOCUMENT_AUTHENTICATION_ENABLED));
72-
$database->query($sqlQuery, array(self::DB_TABLE_WEBSITE_SETTINGS, self::CONFIG_DOCUMENT_AUTHENTICATION_USERNAME));
73-
$database->query($sqlQuery, array(self::DB_TABLE_WEBSITE_SETTINGS, self::CONFIG_DOCUMENT_AUTHENTICATION_PASSWORD));
72+
$sqlQuery = "DELETE FROM ".self::DB_TABLE_WEBSITE_SETTINGS." WHERE name = ?";
73+
$database->query($sqlQuery, array(self::CONFIG_DOCUMENT_AUTHENTICATION_USERNAME));
74+
$database->query($sqlQuery, array(self::CONFIG_DOCUMENT_AUTHENTICATION_PASSWORD));
7475

7576
return 'Successfully removed plugin DocumentAuthentication.';
7677
}
@@ -79,12 +80,11 @@ public static function isInstalled()
7980
{
8081
$database = Pimcore_Resource_Mysql::getConnection();
8182

82-
$sqlQuery= "SELECT COUNT(id) as num FROM ? WHERE name = ?";
83+
$sqlQuery= "SELECT COUNT(id) as num FROM " . self::DB_TABLE_PRE_PROPERTIES . " WHERE name = ?";
8384
$isInstalled = (
8485
(int)$database->fetchOne(
8586
$sqlQuery,
8687
array(
87-
self::DB_TABLE_PRE_PROPERTIES,
8888
self::DOC_PROPERTY_DOCUMENT_AUTHENTICATION_ENABLED
8989
)
9090
) > 0);

plugin.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
<!-- meta data -->
1212
<pluginVersion>1.0</pluginVersion>
13-
<pluginRevision>2</pluginRevision>
13+
<pluginRevision>3</pluginRevision>
1414
<pluginBuildTimestamp>0</pluginBuildTimestamp>
1515

1616
<!-- className of the plugin which extends Pimcore_API_Plugin_Abstract-->

0 commit comments

Comments
 (0)