Skip to content

Fix cdeps propagation through embed chains #4522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jsharpe wants to merge 2 commits into
base: master
Choose a base branch
from
+68 −5
Open

Fix cdeps propagation through embed chains #4522

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a494a68
When a go_library embeds another go_library that has cdeps but not
jsharpe Nov 28, 2025
8823cbb
Add regression test for cdeps propagation through embed chains
jsharpe Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions go/private/context.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,11 +225,17 @@ def _merge_embed(source, embed):
if source["cgo"]:
fail("multiple libraries with cgo enabled")
source["cgo"] = s.cgo
source["cdeps"] = s.cdeps
source["cppopts"] = s.cppopts
source["copts"] = s.copts
source["cxxopts"] = s.cxxopts
source["clinkopts"] = s.clinkopts

# Merge cgo-related attributes if the embedded library has them,
# even if it doesn't have cgo=True itself. This is necessary because
# a library can have cdeps without cgo=True if it embeds another library
# that has cgo=True. The cdeps must propagate through the embed chain.
if s.cdeps or s.cppopts or s.copts or s.cxxopts or s.clinkopts:
source["cdeps"] = source["cdeps"] or s.cdeps
source["cppopts"] = source["cppopts"] or s.cppopts
source["copts"] = source["copts"] or s.copts
source["cxxopts"] = source["cxxopts"] or s.cxxopts
source["clinkopts"] = source["clinkopts"] or s.clinkopts

def _dedup_archives(archives):
"""Returns a list of archives without duplicate import paths.
Expand Down