-
Notifications
You must be signed in to change notification settings - Fork 613
[email protected] #6595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pcj
wants to merge
1
commit into
bazelbuild:main
Choose a base branch
from
stackb:stackb_ui_js-v1.0.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+143
−0
Open
[email protected] #6595
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| module( | ||
| name = "stackb_ui_js", | ||
| version = "1.0.0", | ||
| compatibility_level = 1, | ||
| ) | ||
|
|
||
| # ------------------------------------------------------------------- | ||
| # Bazel Dependencies | ||
| # ------------------------------------------------------------------- | ||
|
|
||
| bazel_dep(name = "stackb_rules_closure", version = "1.0.0") | ||
| bazel_dep(name = "rules_shell", version = "0.6.1", dev_dependency = True) | ||
|
|
||
| # ------------------------------------------------------------------- | ||
| # Dev Dependencies | ||
| # ------------------------------------------------------------------- | ||
|
|
||
| bazel_dep(name = "buildifier_prebuilt", version = "8.2.0.2", dev_dependency = True) | ||
|
|
||
| # ------------------------------------------------------------------- | ||
| # Overrides | ||
| # ------------------------------------------------------------------- | ||
|
|
||
| # Commit: a44b4bc7af840ef4646e41828491691c96e85402 | ||
| # Date: 2025-11-20 00:04:01 +0000 UTC | ||
| # URL: https://github.com/stackb/rules_closure/commit/a44b4bc7af840ef4646e41828491691c96e85402 | ||
| # | ||
| # Merge pull request #6 from stackb/module_rename | ||
| # Size: 5019979 (5.0 MB) | ||
| archive_override( | ||
| module_name = "stackb_rules_closure", | ||
| sha256 = "7d11e93efa87dd27a27c68060cb1b5144a03de80044b58474033546199674083", | ||
| strip_prefix = "rules_closure-a44b4bc7af840ef4646e41828491691c96e85402", | ||
| urls = ["https://github.com/stackb/rules_closure/archive/a44b4bc7af840ef4646e41828491691c96e85402.tar.gz"], | ||
| ) | ||
|
|
||
| # NOTE: cannot upgrade past protobuf editions... | ||
| # | ||
| # Commit: 263ee701cba6b75e1f8eddad5adcdf74718318b1 | ||
| # Date: 2025-10-08 21:32:22 +0000 UTC | ||
| # URL: https://github.com/protocolbuffers/protobuf-javascript/commit/263ee701cba6b75e1f8eddad5adcdf74718318b1 | ||
| # | ||
| # remove writeZigzagVarint64BigInt | ||
| # Size: 401599 (402 kB) | ||
| archive_override( | ||
| module_name = "protobuf_javascript", | ||
| patch_strip = 1, | ||
| patches = [":protobuf_javascript.patch"], | ||
| sha256 = "8a50071fbca5e4a26361e6c9d81dd842207f0005f7cc1720226f20c25a231805", | ||
| strip_prefix = "protobuf-javascript-263ee701cba6b75e1f8eddad5adcdf74718318b1", | ||
| urls = ["https://github.com/protocolbuffers/protobuf-javascript/archive/263ee701cba6b75e1f8eddad5adcdf74718318b1.tar.gz"], | ||
| ) | ||
|
|
||
| # Commit: 04fc63fb40bf30d2e5e0b3786028eb41218de979 | ||
| # Date: 2025-10-09 04:43:15 +0000 UTC | ||
| # URL: https://github.com/stackb/rules_proto/commit/04fc63fb40bf30d2e5e0b3786028eb41218de979 | ||
| # | ||
| # Remove lock file for @maven | ||
| # | ||
| # It is shared by multiple workspaces and seems to cause problems when locked | ||
| # Size: 4088796 (4.1 MB) | ||
| archive_override( | ||
| module_name = "build_stack_rules_proto", | ||
| sha256 = "aff21579deef91316c726582bec71c621dde2ae2ec74099a55b637bda8997333", | ||
| strip_prefix = "rules_proto-04fc63fb40bf30d2e5e0b3786028eb41218de979", | ||
| urls = ["https://github.com/stackb/rules_proto/archive/04fc63fb40bf30d2e5e0b3786028eb41218de979.tar.gz"], | ||
| ) | ||
|
|
||
| # google_bazel_common override is needed for @closure-compiler | ||
| git_override( | ||
| module_name = "google_bazel_common", | ||
| # Pin to newer version to fix b/408030907 | ||
| commit = "2cab52929507935aa43d460a3976d3bedc814d3a", | ||
| remote = "https://github.com/google/bazel-common", | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "mediaType": "application/vnd.build.bazel.registry.attestation+json;version=1.0.0", | ||
| "attestations": { | ||
| "source.json": { | ||
| "url": "https://github.com/stackb/ui.js/releases/download/v1.0.0/source.json.intoto.jsonl", | ||
| "integrity": "sha256-A7Cop66MjN0x7Mk6Zr+5x68Y6kMqa7l/coMKW4rgwRU=" | ||
| }, | ||
| "MODULE.bazel": { | ||
| "url": "https://github.com/stackb/ui.js/releases/download/v1.0.0/MODULE.bazel.intoto.jsonl", | ||
| "integrity": "sha256-5839/aA6aR//G4sYs0St1o9CqAdWNNAqVejIqZaJLv4=" | ||
| }, | ||
| "ui.js-v1.0.0.tar.gz": { | ||
| "url": "https://github.com/stackb/ui.js/releases/download/v1.0.0/ui.js-v1.0.0.tar.gz.intoto.jsonl", | ||
| "integrity": "sha256-WVzz2j98NFzG1YTmo324ZL86o0LGZNjVXzbXbB7gl3s=" | ||
| } | ||
| } | ||
| } |
12 changes: 12 additions & 0 deletions
12
modules/stackb_ui_js/1.0.0/patches/module_dot_bazel_version.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| =================================================================== | ||
| --- a/MODULE.bazel | ||
| +++ b/MODULE.bazel | ||
| @@ -1,7 +1,7 @@ | ||
| module( | ||
| name = "stackb_ui_js", | ||
| - version = "0.0.0", | ||
| + version = "1.0.0", | ||
| compatibility_level = 1, | ||
| ) | ||
|
|
||
| # ------------------------------------------------------------------- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| bcr_test_module: | ||
| module_path: "." | ||
| matrix: | ||
| platform: ["debian11", "ubuntu2404", "macos"] | ||
| bazel: [7.x, 8.x] | ||
| tasks: | ||
| run_tests: | ||
| name: "Build module" | ||
| platform: ${{ platform }} | ||
| bazel: ${{ bazel }} | ||
| test_targets: | ||
| - "//..." | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "integrity": "sha256-uuW7K2oIRFq9v4YVqUVAfvSlkWuzM98j7lbLRsbz1Dw=", | ||
| "strip_prefix": "ui.js-v1.0.0", | ||
| "url": "https://github.com/stackb/ui.js/releases/download/v1.0.0/ui.js-v1.0.0.tar.gz", | ||
| "patches": { | ||
| "module_dot_bazel_version.patch": "sha256-geEF82mKNkjLhjnY9Oq3A2GnZQPDxplcvwWChyDfmL8=" | ||
| }, | ||
| "patch_strip": 1 | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "homepage": "https://github.com/stackb/ui.js", | ||
| "maintainers": [ | ||
| { | ||
| "name": "Paul Cody", | ||
| "email": "[email protected]", | ||
| "github_user_id": 50580, | ||
| "github": "pcj" | ||
| } | ||
| ], | ||
| "repository": [ | ||
| "github:stackb/ui.js" | ||
| ], | ||
| "versions": [ | ||
| "1.0.0" | ||
| ], | ||
| "yanked_versions": {} | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The task is named "Build module", but it only specifies
test_targets. This is misleading and could result in presubmit checks passing vacuously if no test targets are found. To make the presubmit more robust, this suggestion addsbuild_targetsto ensure all library targets are buildable and renames the task for clarity. The list format forbuild_targetsandtest_targetsis changed to flow style to fit the suggestion within the original line count.