Replace unknownSsin issue type by referencedResourceNotFound (#66)

Fix #65.

Author: jpraet

belgif-rest-problem/src/main/java/io/github/belgif/rest/problem/api/InputValidationIssues.java

@@ -38,8 +38,6 @@ public class InputValidationIssues {
             URI.create("urn:problem-type:cbss:input-validation:replacedSsin");
     public static final URI ISSUE_TYPE_CANCELED_SSIN =
             URI.create("urn:problem-type:cbss:input-validation:canceledSsin");
-    public static final URI ISSUE_TYPE_UNKNOWN_SSIN =
-            URI.create("urn:problem-type:cbss:input-validation:unknownSsin");
     public static final URI ISSUE_TYPE_INVALID_PERIOD =
             URI.create("urn:problem-type:cbss:input-validation:invalidPeriod");
 
@@ -150,9 +148,7 @@ public static InputValidationIssue invalidSsin(InEnum in, String name, String ss
     }
 
     public static InputValidationIssue unknownSsin(InEnum in, String name, String ssin) {
-        return new InputValidationIssue(ISSUE_TYPE_UNKNOWN_SSIN, "SSIN does not exist")
-                .detail(String.format("SSIN %s does not exist", ssin))
-                .in(in, name, ssin);
+        return referencedResourceNotFound(in, name, ssin).detail(String.format("SSIN %s does not exist", ssin));
     }
 
     public static InputValidationIssue invalidPeriod(InEnum in, String name, Object period) {

belgif-rest-problem/src/test/java/io/github/belgif/rest/problem/api/InputValidationIssuesTest.java

@@ -198,8 +198,8 @@ void invalidSsin() {
     void unknownSsin() {
         InputValidationIssue issue =
                 InputValidationIssues.unknownSsin(InEnum.BODY, "ssin", "00000000196");
-        assertThat(issue.getType()).hasToString("urn:problem-type:cbss:input-validation:unknownSsin");
-        assertThat(issue.getTitle()).isEqualTo("SSIN does not exist");
+        assertThat(issue.getType()).hasToString("urn:problem-type:cbss:input-validation:referencedResourceNotFound");
+        assertThat(issue.getTitle()).isEqualTo("Referenced resource not found");
         assertThat(issue.getIn()).isEqualTo(InEnum.BODY);
         assertThat(issue.getName()).isEqualTo("ssin");
         assertThat(issue.getValue()).isEqualTo("00000000196");

src/main/asciidoc/index.adoc

@@ -33,6 +33,7 @@ The library consists of these modules:
 *belgif-rest-problem:*
 
 * Removed deprecated InvalidParamProblem: use InputValidationProblem, which supports both the legacy invalidParams[] and the new issues[] structure
+* Replace specific `urn:problem-type:cbss:input-validation:unknownSsin` issue type by generic  `urn:problem-type:cbss:input-validation:referencedResourceNotFound`
 
 *belgif-rest-problem-validator:*