Skip to content

Commit 714d1e0

Browse files
committed
document intentional graceful degradation
1 parent ac9181d commit 714d1e0

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

pkg/dbconn/conn.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -385,8 +385,8 @@ func EnhanceDSNWithTLS(inputDSN string, config *DBConfig) (string, error) {
385385

386386
cfg, err := mysql.ParseDSN(inputDSN)
387387
if err != nil {
388-
_ = err // Explicitly ignore parsing error for graceful degradation
389-
return inputDSN, nil // Return original DSN without error if parsing fails
388+
// Return original DSN for graceful degradation when parsing fails
389+
return inputDSN, nil //nolint:nilerr // Intentional graceful degradation
390390
}
391391

392392
// If DSN already has TLS configuration, respect it
@@ -464,8 +464,8 @@ func addTLSParametersToDSN(dsn string, config *DBConfig) (string, error) {
464464
func createFallbackDSN(inputDSN string) (string, error) {
465465
cfg, err := mysql.ParseDSN(inputDSN)
466466
if err != nil {
467-
_ = err // Explicitly ignore parsing error for graceful degradation
468-
return inputDSN, nil // Return original DSN without error if parsing fails
467+
// Return original DSN for graceful degradation when parsing fails
468+
return inputDSN, nil //nolint:nilerr // Intentional graceful degradation
469469
}
470470

471471
// Remove TLS configuration - both from TLSConfig field and params

0 commit comments

Comments
 (0)