Skip to content

ed: initial support for global (g) command #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
briandfoy merged 1 commit into from
Oct 19, 2024
Merged

ed: initial support for global (g) command #765

briandfoy merged 1 commit into from
Oct 19, 2024

Conversation

@mknos
Copy link
Contributor

@mknos mknos commented Oct 19, 2024

  • Basic usage of g command is to show lines matching a pattern
  • More advanced use of g command would be to modify the buffer; this needs more work
  • test1: g/text not found/p ---> no error is printed (consistent with BSD and GNU version)
  • test2: g/include/p ---> print matching lines
  • test3: g/include/n ---> prefix matching lines with line number
  • test4: g/t/l ---> matching lines are listed in with escapes

@mknos
ed: initial support for global (g) command
929ca8b 
* Basic usage of g command is to show lines matching a pattern
* More advanced use of g command would be to modify the buffer; this needs more work
* test1: g/text not found/p ---> no error is printed (consistent with BSD and GNU version)
* test2: g/include/p ---> print matching lines
* test3: g/include/n ---> prefix matching lines with line number
* test4: g/t/l ---> matching lines are listed in with escapes
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Oct 19, 2024
@mknos mknos temporarily deployed to automated_testing October 19, 2024 01:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 19, 2024 01:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 19, 2024 01:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 19, 2024 01:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 19, 2024 01:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 19, 2024 01:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 19, 2024 01:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 19, 2024 01:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 19, 2024 01:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 19, 2024 01:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 19, 2024 01:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 19, 2024 01:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 19, 2024 01:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 19, 2024 01:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 19, 2024 01:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 19, 2024 01:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 19, 2024 01:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 19, 2024 01:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 19, 2024 01:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 19, 2024 01:19 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Oct 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11413296434

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11408363703: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy self-assigned this Oct 19, 2024
@briandfoy briandfoy merged commit 437e404 into briandfoy:master Oct 19, 2024
21 checks passed
@briandfoy
Copy link
Owner

briandfoy commented Oct 19, 2024

changes: add g command to grep a buffer

@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Oct 19, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels

Program: ed The ed program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mknos @coveralls @briandfoy