Skip to content

cmp: 0X and 0x are valid hex prefix #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2025
Merged

cmp: 0X and 0x are valid hex prefix #971

merged 1 commit into from
Feb 26, 2025
+2 −2

Conversation

@mknos
Copy link
Contributor

@mknos mknos commented Feb 26, 2025

  • Skip numbers (optional arguments 3 & 4) can be specified in decimal or hex
  • When testing on OpenBSD and Linux, "0X" hex prefix is supported, so add it to this version too
  • I didn't test on NetBSD, but the NetBSD version calls the C strotoll() function, which is documented to accept "0X" [1] [2]
  • Tweak POD manual
  1. https://cvsweb.netbsd.org/bsdweb.cgi/src/usr.bin/cmp/cmp.c?annotate=1.21 line128
  2. https://man.netbsd.org/strtoll.3
%ifconfig > F1
%cp F1 F2
%perl cmp F1 F2
%perl cmp F1 F2 0x1 0X1 # same skip, different prefix, same day
%perl cmp F1 F2 0x1 0X2
F1 F2 differ: char 1, line 1

@mknos
cmp: 0X and 0x are valid hex prefix
b4f12c7 
* Skip numbers (optional arguments 3 & 4) can be specified in decimal or hex
* When testing on OpenBSD and Linux, "0X" hex prefix is supported, so add it to this version
* I didn't test on NetBSD but the source code calls C strotoll() function, which is documented to accept "0X" [1] [2]
* Tweak POD manual

1. https://cvsweb.netbsd.org/bsdweb.cgi/src/usr.bin/cmp/cmp.c?annotate=1.21  line128
2. https://man.netbsd.org/strtoll.3
@github-actions github-actions bot added Priority: low get to this whenever Status: needs verification issue needs to be verified Type: bug an existing feature does not work Type: enhancement improve a feature that already exists Program: cmp The cop program labels Feb 26, 2025
@mknos mknos temporarily deployed to automated_testing February 26, 2025 09:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 26, 2025 09:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 26, 2025 09:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 26, 2025 09:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 26, 2025 09:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 26, 2025 09:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 26, 2025 09:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 26, 2025 09:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 26, 2025 09:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 26, 2025 09:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 26, 2025 09:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 26, 2025 09:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 26, 2025 09:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 26, 2025 09:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 26, 2025 09:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 26, 2025 09:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 26, 2025 09:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 26, 2025 09:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 26, 2025 09:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 26, 2025 09:05 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Feb 26, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13540235823

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.085%
Totals Coverage Status
Change from base Build 13523294333: 0.0%
Covered Lines: 353
Relevant Lines: 483
💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Feb 26, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13540235823

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.085%
Totals Coverage Status
Change from base Build 13523294333: 0.0%
Covered Lines: 353
Relevant Lines: 483
💛 - Coveralls

@briandfoy briandfoy added the Type: documentation fix the docs label Feb 26, 2025
@briandfoy
Copy link
Owner

briandfoy commented Feb 26, 2025

changes: skip values can be decimal or hex; 0X and 0x are supported

@briandfoy briandfoy merged commit 06bad35 into briandfoy:master Feb 26, 2025
24 checks passed
@briandfoy briandfoy self-assigned this Feb 26, 2025
@github-actions github-actions bot added Status: accepted The fix is accepted and removed Status: needs verification issue needs to be verified Priority: low get to this whenever labels Feb 26, 2025
@briandfoy briandfoy removed the Type: bug an existing feature does not work label Feb 26, 2025
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels

Program: cmp The cop program Status: released there is a new release with this fix Type: documentation fix the docs Type: enhancement improve a feature that already exists

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mknos @coveralls @briandfoy