Skip to content

chgrp: fail early for empty string #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2025
Merged

chgrp: fail early for empty string #977

merged 1 commit into from
Mar 4, 2025

Conversation

@mknos
Copy link
Contributor

@mknos mknos commented Mar 4, 2025

  • Similar to commit 471e64b for bin/chown
  • Fail early if the 1st (group) argument is an empty string to avoid unnecessary getgrnam('') call
  • style: forward declaration of modify_file() is not needed if the method is called with parens
  • style: move default exit() statement above the subroutine declarations, as done in other scripts

@mknos
chgrp:
4f423d0 
* Similar to commit 471e64b for bin/chown
* Fail early if the 1st (group) argument is an empty string to avoid unnecessary getgrnam('') call
* style: forward declaration of modify_file() is not needed if the method is called with parens
* style: move default exit() statement above the subroutine declarations, as done in other scripts
@mknos mknos temporarily deployed to housekeeping March 4, 2025 00:52 — with GitHub Actions Inactive
@github-actions github-actions bot added Priority: low get to this whenever Status: needs verification issue needs to be verified Type: bug an existing feature does not work labels Mar 4, 2025
@github-actions github-actions bot requested a review from briandfoy March 4, 2025 00:53
@mknos mknos temporarily deployed to automated_testing March 4, 2025 00:53 — with GitHub Actions Inactive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Program: chgrp The chgrp program labels Mar 4, 2025
@mknos mknos temporarily deployed to automated_testing March 4, 2025 00:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing March 4, 2025 00:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing March 4, 2025 00:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing March 4, 2025 00:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing March 4, 2025 00:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing March 4, 2025 00:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing March 4, 2025 00:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing March 4, 2025 00:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing March 4, 2025 00:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing March 4, 2025 00:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing March 4, 2025 00:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing March 4, 2025 00:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing March 4, 2025 00:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing March 4, 2025 00:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing March 4, 2025 00:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing March 4, 2025 00:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing March 4, 2025 00:53 — with GitHub Actions Inactive
@mknos mknos had a problem deploying to automated_testing March 4, 2025 00:53 — with GitHub Actions Failure
@mknos mknos had a problem deploying to automated_testing March 4, 2025 00:54 — with GitHub Actions Error
@coveralls
Copy link

coveralls commented Mar 4, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13643737383

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.9%) to 70.088%
Files with Coverage Reduction New Missed Lines %
bin/glob 1 57.14%
bin/units 3 69.91%
Totals Coverage Status
Change from base Build 13632474012: -0.9%
Covered Lines: 396
Relevant Lines: 565
💛 - Coveralls

@briandfoy briandfoy self-assigned this Mar 4, 2025
@briandfoy briandfoy merged commit 0fd0e9c into briandfoy:master Mar 4, 2025
21 of 24 checks passed
@github-actions github-actions bot removed Status: needs verification issue needs to be verified Priority: low get to this whenever labels Mar 4, 2025
@briandfoy
Copy link
Owner

briandfoy commented Mar 4, 2025

changes: fail if the group is the empty string

@github-actions github-actions bot added the Status: accepted The fix is accepted label Mar 4, 2025
@briandfoy briandfoy removed the Type: enhancement improve a feature that already exists label Mar 4, 2025
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels

Program: chgrp The chgrp program Status: released there is a new release with this fix Type: bug an existing feature does not work

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mknos @coveralls @briandfoy