date: too much whitespace for %e format #987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mknos
commented
Mar 14, 2025
mknos
commented
- I was tracking why the Perl date command separated Mar and 14 with 2 spaces instead of one
- The default strftime() format string is "%a %b %e %T %Z %Y"
- The Linux manual for strftime() says %e is the same as %d, except that a leading zero is replaced with a leading space
- So day 1 would be "01" and " 1", but day 10 would have no leading space or zero
- Formatting the day number with "%2d" is good enough for %e specifier; previously day 14 was formatted as " 14" in setup_specifiers()
* I was tracking why the Perl date command separated Mar and 14 with 2 spaces instead of one * The default strftime() format string is "%a %b %e %T %Z %Y" * The Linux manual for strftime() says %e is the same as %d, except that a leading zero is replaced with a leading space * So day 1 would be "01" and " 1", but day 10 would have no leading space/zero * Formatting the day number with "%2d" is good enough for %e specifier; previously day 14 was formatted as " 14" in setup_specifiers() %perl date # with patch Fri Mar 14 09:11:30 AWST 2025 %date # GNU Fri Mar 14 09:11:31 AM AWST 2025
mknos
had a problem deploying
to
automated_testing
GitHub Actions
Failure
github-actions
bot
added
Type: enhancement
Pull Request Test Coverage Report for Build 13848121532Details
💛 - Coveralls |
briandfoy
reviewed
Mar 14, 2025
|
|
||
| sub setup_specifiers { | ||
| my %specifiers = ( | ||
| 'e' => sprintf( '% 2d', (core_time)[3] ), |
Owner
There was a problem hiding this comment.
Huh, I did not know the space acted like that, but looking at the docs, that's what it does.
briandfoy
approved these changes
Mar 14, 2025
Owner
|
changes: don't prepend space to the day of the month |
github-actions
bot
added
Status: accepted
briandfoy
added
Status: released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.