-
Notifications
You must be signed in to change notification settings - Fork 1.6k
filesystem: ErrorCode::IsDirectory when opening directory w/o READ #12136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
In all honesty I haven't tested on Windows, it's just that this patch should fix the issue. To repro, check out the |
2e830ac to
6cd0e89
Compare
|
Rebased to fix the rustfmt error |
On Windows, it was possible to return a directory descriptor if READ wasn't in the permissions. Fixes wasmtime for WebAssembly/wasi-testsuite#176.
6cd0e89 to
a7831bf
Compare
|
My goodness, there are many CI checks in this project :) Patch fixes unused-variable warning/error when compiling for Windows. |
You can add |
|
Test-wise this is something that'll be caught when updating to the latest wasi-testsuite, right? If so, I think it's ok to skip a test here. Mind leaving a comment though on this match arm explaining that this is sync'ing windows semantics to unix semantics? |
On Windows, it was possible to return a directory descriptor if READ wasn't in the permissions. Fixes wasmtime for
WebAssembly/wasi-testsuite#176.