Use OptionsIndex more internally in components
#11986
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates various runtimes bits for components to use `OptionsIndex` more aggressively and ultimately deletes the old `Options` type. The `Options` type is a heavyweight package of all possible options which is effectively a duplication of what `OptionsIndex` points to, so that's removed in favor of directly accessing options.
alexcrichton
commented
Nov 5, 2025
| } | ||
|
|
||
| async fn write<D: 'static, P: Send + 'static, T: func::Lower + 'static, B: WriteBuffer<T>>( | ||
| instance: Option<Instance>, |
Member
Author
There was a problem hiding this comment.
@dicej your scrutiny here would be appreciated. I'm relatively sure this removal is "accurate", but I'm not sure if it should cascade in more removals as well (e.g. instance => _instance above as opposed to removing it entirely)
Contributor
There was a problem hiding this comment.
Looks reasonable to me, and I would indeed cascade the removals. No point in passing unused parameters around.
github-actions
bot
added
the
wasmtime:api
dicej
approved these changes
Nov 10, 2025
| } | ||
|
|
||
| async fn write<D: 'static, P: Send + 'static, T: func::Lower + 'static, B: WriteBuffer<T>>( | ||
| instance: Option<Instance>, |
Contributor
There was a problem hiding this comment.
Looks reasonable to me, and I would indeed cascade the removals. No point in passing unused parameters around.
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Nov 10, 2025
Some follow-up work to delete more unnecessary parameter-passing.
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates various runtimes bits for components to use
OptionsIndexmore aggressively and ultimately deletes the oldOptionstype. TheOptionstype is a heavyweight package of all possible options which is effectively a duplication of whatOptionsIndexpoints to, so that's removed in favor of directly accessing options.