Skip to content

Commit c4f42b7

Browse files
authored
chore: Pass domain/cluster to cronListEnabled (#1114)
Signed-off-by: Tim Chan <[email protected]>
1 parent cf827a5 commit c4f42b7

File tree

5 files changed

+22
-5
lines changed

5 files changed

+22
-5
lines changed

src/config/dynamic/dynamic.config.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import clustersPublic from './resolvers/clusters-public';
1212
import { type PublicClustersConfigs } from './resolvers/clusters-public.types';
1313
import { type ClustersConfigs } from './resolvers/clusters.types';
1414
import cronListEnabled from './resolvers/cron-list-enabled';
15+
import { type CronListEnabledResolverParams } from './resolvers/cron-list-enabled.types';
1516
import extendedDomainInfoEnabled from './resolvers/extended-domain-info-enabled';
1617
import { type ExtendedDomainInfoEnabledConfig } from './resolvers/extended-domain-info-enabled.types';
1718
import failoverHistoryEnabled from './resolvers/failover-history-enabled';
@@ -38,7 +39,7 @@ const dynamicConfigs: {
3839
true
3940
>;
4041
CRON_LIST_ENABLED: ConfigAsyncResolverDefinition<
41-
undefined,
42+
CronListEnabledResolverParams,
4243
boolean,
4344
'request',
4445
true
Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
1-
export default async function cronListEnabled(): Promise<boolean> {
1+
import { type CronListEnabledResolverParams } from './cron-list-enabled.types';
2+
3+
export default async function cronListEnabled(
4+
_: CronListEnabledResolverParams
5+
): Promise<boolean> {
26
// Check for environment variable override, default to false (disabled)
37
return process.env.CRON_LIST_ENABLED?.toLowerCase() === 'true';
48
}
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
export type CronListEnabledResolverParams = {
2+
domain: string;
3+
cluster: string;
4+
};

src/config/dynamic/resolvers/schemas/resolver-schemas.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,10 @@ const resolverSchemas: ResolverSchemas = {
4545
}),
4646
},
4747
CRON_LIST_ENABLED: {
48-
args: z.undefined(),
48+
args: z.object({
49+
cluster: z.string(),
50+
domain: z.string(),
51+
}),
4952
returnType: z.boolean(),
5053
},
5154
EXTENDED_DOMAIN_INFO_ENABLED: {

src/views/domain-page/domain-page-tabs/domain-page-tabs.tsx

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,13 @@ export default function DomainPageTabs() {
2727
'FAILOVER_HISTORY_ENABLED'
2828
);
2929

30-
const { data: isCronListEnabled } =
31-
useSuspenseConfigValue('CRON_LIST_ENABLED');
30+
const { data: isCronListEnabled } = useSuspenseConfigValue(
31+
'CRON_LIST_ENABLED',
32+
{
33+
domain: decodedParams.domain,
34+
cluster: decodedParams.cluster,
35+
}
36+
);
3237

3338
const tabsConfig = useMemo<Partial<typeof domainPageTabsConfig>>(() => {
3439
const tabsToHide: Array<DomainPageTabName> = [];

0 commit comments

Comments
 (0)