Merge pull request #411 from cakephp/persist-identity

Remove unneeded check and update testcase.

Author: markstory

src/AuthenticationService.php

@@ -247,9 +247,7 @@ public function persistIdentity(ServerRequestInterface $request, ResponseInterfa
             }
         }
 
-        if (!($identity instanceof IdentityInterface)) {
-            $identity = $this->buildIdentity($identity);
-        }
+        $identity = $this->buildIdentity($identity);
 
         return [
             'request' => $request->withAttribute($this->getConfig('identityAttribute'), $identity),

tests/TestCase/AuthenticationServiceTest.php

@@ -396,13 +396,13 @@ public function testPersistIdentityInterface()
     {
         $request = new ServerRequest();
         $response = new Response();
-        $identity = $this->createMock(IdentityInterface::class);
+        $identity = new ArrayObject();
 
         $service = new AuthenticationService();
 
         $result = $service->persistIdentity($request, $response, $identity);
 
-        $this->assertSame($identity, $result['request']->getAttribute('identity'));
+        $this->assertInstanceOf(IdentityInterface::class, $result['request']->getAttribute('identity'));
     }
 
     /**