-
Notifications
You must be signed in to change notification settings - Fork 85
docs: add audio explanation #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @edibotopic, I'm done with @eeickmeyer comments. Feel free to take a look now. |
|
Just a little bit that might be important: However, there is a file, on amd64 systems in In the package Once that is done, an Source for that is here: https://git.launchpad.net/ubuntustudio-default-settings/tree/debian/ubuntustudio-pipewire-config.postinst So, while installing |
Thanks for pointing it out. I'll add a note for it soon. |
@eeickmeyer Done. |
|
@davidekete --- apologies for the delay. I'm hoping to take a look this week. |
edibotopic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work!!!
I enjoyed reading this.
I have added a few minor comments for you to consider.
Co-authored-by: Shane Crowley <[email protected]>
Co-authored-by: Shane Crowley <[email protected]>
Co-authored-by: Shane Crowley <[email protected]>
Co-authored-by: Shane Crowley <[email protected]>
Co-authored-by: Shane Crowley <[email protected]>
Co-authored-by: Shane Crowley <[email protected]>
Co-authored-by: Shane Crowley <[email protected]>
Co-authored-by: Shane Crowley <[email protected]>
Co-authored-by: Shane Crowley <[email protected]>
Co-authored-by: Shane Crowley <[email protected]>
Co-authored-by: Shane Crowley <[email protected]>
|
@eeickmeyer --- I reviewed the most recent version of this PR. Do you want to have a look again, or are you happy to approve? |
|
Ok, looks good now! 👍 |
Closes issue #197 @edibotopic