Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions website/library/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,5 +48,6 @@ This section is currently under development. If you'd like to contribute, please
:maxdepth: 2

Reference <reference/index>
Tutorials <tutorials/index>

```
45 changes: 0 additions & 45 deletions website/library/reference/how-to-review-someones-work.md

This file was deleted.

1 change: 0 additions & 1 deletion website/library/reference/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
:maxdepth: 1

Links for technical writers <links-for-technical-writers>
How to review someones work <how-to-review-someones-work>
How to implement peer reviewers feedback <how-to-implement-peer-reviewers-feedback>

```
70 changes: 70 additions & 0 deletions website/library/tutorials/craft-a-constructive-peer-review.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
# Craft a constructive peer review
Whether you are an experienced peer reviewer or someone wanting to give a peer review for the first time, this tutorial will help you craft constructive feedback. The approaches you will learn in this tutorial can be applied to peer reviews on documentation and can be used to improve your feedback on any topic.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the first sentence of this introduction feels superfluous here, but would make a really nice contextual snippet to introduce the page on the landing page it's linked from (adding this sort of introduction text on the landing pages can help them feel more "friendly").

The second sentence, imo, is strong enough to stand alone as a really strong introductory paragraph that tells the reader exactly what to expect from the page.


## What is a peer review?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section feels a bit at odds with the header. I think a more relevant header would be something like "Why should we peer review?" or "Why are peer reviews important?"

A peer review is about making sure the content is the strongest version of itself—for now—while also making contributors feel valued and supported. It is a key skill to build early in your technical writing journey. Offering your perspective to other writers helps make the content clearer and more useful for readers. Peer reviews also help you collaborate effectively with other writers and stakeholders, and they strengthen your own writing over time.

## How can I make my peer review constructive?

### Start with the positive
Start with the positive to create an environment where people feel valued. It encourages them to contribute again.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good here to include some practical tips for what "start with the positive" looks like in practice - by itself it feels a bit vague. You may want to include something like "Begin your review by highlighting the things the contributor did well, or by thanking them for their contribution". It might also be good to point to conventional comments or something like that

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might also be good to point out here in this section that that doesn't mean one should only be positive - but that it's about framing any changes you want the contributor to make in a constructive way: that a) will make sense to them/are not arbitrary, b) are specific and actionable and c) are not negative/bashing. The examples you give in the following section are perfect supporting material for the general principles, but I think these principles should be clearly set out.


### Focus on the document
When proposing improvements, focus your feedback on the document, the task, or the users, and not on the person. See how those two sentences feel different: _“**You** didn’t clarify this aspect.”_ and _“**The document** doesn’t clarify this aspect.”_ With this approach in mind, you reduce the risks that contributors may feel attacked or demotivated by your feedback.

On the other hand, it is usually fine to talk about the person when giving positive feedback: _“I like how **you** approached this particular aspect.”_

### Explain your reasons
Provide guidance and explain the reasons why you are proposing changes. It helps contributors learn, and they will be able to spot mistakes or improvements by themselves in the future.

### Provide concrete examples
Support your ideas with concrete examples and explain how to implement your feedback.

**_Note_**: Be mindful of the number of concrete examples you provide. Sometimes one or two key examples are enough to set the contributors up for success without overwhelming them.

### Don’t forget the bigger picture
Lastly, think about what can be improved from the general process. Let’s say a contributor provided a document way below your expectations:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"from the general process" feels a little vague. I think it's actually fine to directly suggest that the reviewer's own processes share some of the blame for that (but in a constructive way). Perhaps something like:
"If you received a contribution that fell way below your expectations, it may be that there are improvements you can make in your contributor workflows. For example, are your README and contribution guidelines clear enough? Did you provide enough instruction in the original issue? Do they include all the relevant links a contributor might need? Are they explicit about what's expected? If not, this is a great place to look at making general improvements. Asking the contributor for feedback about their experience of contributing can also be really helpful, and will help to improve the experience for future contributors."

* Were the task and its goal clear to begin with?
* Were enough useful resources provided?
* Could a template or style guide have helped?

## Summary
When you put what you’ve learned so far into practice, a constructive peer review may look something like this: _“Thank you for your contribution, I like how you [**positive feedback**]. Additionally, **our users** would benefit from having this aspect explained because [**reasons**]. Here is how I would apply it: [**concrete example**]. Lastly, you can take a look at our **style guide** that I forgot to link in the initial issue (sorry for that!). ”_

<!---
### Content Review

* **Overall structure and flow**:
* Are the steps presented in a logical sequence that guides the user effectively?
* Is the language simple for the user to understand?
* Have all the terms been clearly defined?
* **Accuracy and completeness**:
* Does the document present any information that could be unclear or misleading to the user?
* Are all steps accurate and free from mistakes?
* Do the steps' code snippets work when followed?

### Clarity and Readability

* **Formatting and consistency**:
* Are headings and subheadings used consistently?
* Are lists and tables used effectively?
* Are images and diagrams used to support the text?

### Mechanics and Style

* **Spelling and grammar**:
* Are there any spelling or grammar errors?
* Are punctuation and capitalization consistent?
* **Style and tone**:
* Is the tone consistent throughout the document?
* Are there any areas where the tone could be improved?

### Additional Checks

* **Links and references**:
* Are all links working correctly?
* Are references properly cited?
* **Examples**:
* Do the real-world examples effectively enhance the understanding of the documentation's topic?
* Do the real-world examples resonate with the user?
-->
8 changes: 8 additions & 0 deletions website/library/tutorials/index.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# Tutorials

```{toctree}
:maxdepth: 1

Craft a constructive peer review <craft-a-constructive-peer-review>

```