Improve containerized command detection

Instead of only looking for `docker exec` we check for multiple
applications able to run Cap'n inside a container.

Current candidates:
 - docker
 - docker-compose
 - podman
 - sail

Author: sebastianfeldmann

src/Hook/Template/Docker.php

@@ -107,11 +107,11 @@ public function getCode(string $hook): string
      */
     private function getOptimizeDockerCommand(string $hook): string
     {
-        $command  = $this->config->getRunConfig()->getDockerCommand();
-        $position = strpos($command, 'docker exec');
-        // add interactive and tty flags if docker exec is used
-        if ($position !== false) {
-            $endExec    = $position + 11;
+        $command = $this->config->getRunConfig()->getDockerCommand();
+        $endExec = $this->endOfExecPositionInCommand($command);
+
+        // if the docker command can be identified, add env vars and tty flags
+        if ($endExec !== -1) {
             $executable = substr($command, 0, $endExec);
             $options    = substr($command, $endExec);
 
@@ -228,4 +228,30 @@ private function resolveBinaryPath(): string
         // you have to use the 'run' 'path' config then
         return $this->pathInfo->getExecutablePath();
     }
+
+    /**
+     * Look for the docker exec position in the command
+     *
+     * The position is necessary to optimize the interactive and env variable settings.
+     * Returns -1 if nothing can be detected.
+     *
+     * This detection works with:
+     *  - docker
+     *  - docker-compose
+     *  - podman
+     *  - sail
+     *
+     * @param string $command
+     * @return int
+     */
+    private function endOfExecPositionInCommand(string $command): int
+    {
+        // find the exec command to extract the options later on and improve them
+        $regex   = '~(?:^|[\s;|&])(?:[\w./-]*/)?(docker|docker-compose|podman|sail)\s+exec\b~i';
+        $matches = [];
+        if (preg_match($regex, $command, $matches)) {
+            return strlen($matches[0]);
+        }
+        return -1;
+    }
 }

tests/unit/Hook/Template/DockerTest.php

@@ -105,6 +105,28 @@ public function testDockerCommandOptimizationWithoutGitMapping(string $exec, str
         $this->assertStringContainsString('/usr/local/bin/captainhook', $code);
     }
 
+    public function testDoesNotOptimizeUnrecognizedCommands(): void
+    {
+        $pathInfo = $this->createMock(PathInfo::class);
+        $pathInfo->method('getExecutablePath')->willReturn('./vendor/bin/captainhook');
+        $pathInfo->method('getConfigPath')->willReturn('captainhook.json');
+
+        $configMock = $this->createConfigMock(false, 'captainhook.json');
+        $runConfig  = new Run([
+            'mode' => 'docker',
+            'exec' => 'custom-exec my-container',
+            'path' => '/usr/local/bin/captainhook'
+        ]);
+        $configMock->method('getBootstrap')->willReturn('');
+        $configMock->method('getRunConfig')->willReturn($runConfig);
+
+        $template = new Docker($pathInfo, $configMock);
+        $code     = $template->getCode('prepare-commit-msg');
+
+        $this->assertStringContainsString('/usr/local/bin/captainhook', $code);
+        $this->assertStringNotContainsString('GIT_INDEX_FILE', $code);
+    }
+
     public static function replacementPossibilitiesWithoutGitMapping(): array
     {
         return [