Skip to content

Conversation

@jrobichaud
Copy link
Contributor

@jrobichaud jrobichaud commented Mar 27, 2025

  • remove reference to django 3.2, 4.1, 4.2 (EOL)
  • remove python 3.8 (EOL)
  • replace pypy-3.10 with pypy-3.11
  • add django 5.2rc1 to tox
  • make sure tools runs with 3.9
  • tell readthedocs to use latest python and ubuntu lts

@codecov
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.42%. Comparing base (082e5f5) to head (8152b1b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #863   +/-   ##
=======================================
  Coverage   87.42%   87.42%           
=======================================
  Files          32       32           
  Lines         954      954           
  Branches       76       76           
=======================================
  Hits          834      834           
  Misses        102      102           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jrobichaud jrobichaud changed the title Set all the version numbers correctly Set all the python/django version numbers correctly Mar 27, 2025
@jrobichaud jrobichaud mentioned this pull request Mar 27, 2025
fail-fast: false
matrix: # https://docs.djangoproject.com/en/stable/faq/install/#what-python-version-can-i-use-with-django
django-version: ["3.2", "4.2", "5.0", "5.1", "5.2rc1"]
django-version: ["4.2", "5.0", "5.1", "5.2rc1"]
Copy link
Contributor

@cclauss cclauss Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@auvipy Are you OK with dropping Python 3.8 and Django v3.2 support?

Would this fail if we had "5.2" instead of "5.2rc1"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the moment yes.

Co-authored-by: Christian Clauss <[email protected]>
@jrobichaud
Copy link
Contributor Author

@cclauss when django 5.2 will be officially out we will be able to change 5.2rc1 to 5.2.

Pre-releases have to be exact matches.

@jrobichaud jrobichaud requested a review from cclauss March 28, 2025 11:58
@jrobichaud
Copy link
Contributor Author

jrobichaud commented Mar 28, 2025

In a few days we will be able to make a new PR replacing 5.2rc1 with 5.2.

@jrobichaud
Copy link
Contributor Author

jrobichaud commented Mar 28, 2025

@cclauss, I let you resolve the conversations if you are satisfied with the fixes. When this one is merged, I have another one I will submit to be merged when django 5.2 will be out officially. (the commit of the future PR ca5fd08)

Comment on lines 48 to 50
tox -- --cov=django_celery_beat --cov-report=xml --no-cov-on-fail --cov-report term
else
tox
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I see... I usually run these with tox -e py as mentioned at https://docs.github.com/en/actions/use-cases-and-examples/building-and-testing/building-and-testing-python#running-tests-with-tox which gives that flexibility. Without -e py things have to be hard coded.

@cclauss cclauss requested a review from auvipy March 28, 2025 13:43
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im going to hold this

@jrobichaud
Copy link
Contributor Author

@auvipy , on hold like waiting for django 5.2 to release?

If so, I will just replace the 5.2rc1 to 5.2 already.

Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed by #865

@auvipy
Copy link
Member

auvipy commented Mar 29, 2025

@auvipy , on hold like waiting for django 5.2 to release?

If so, I will just replace the 5.2rc1 to 5.2 already.

we tend to keep bit older versions supported to make the transition easier for legacy projects. thanks for you efforts though. the CI was not fully synced so I have to take care of them.

@auvipy auvipy closed this Mar 29, 2025
@jrobichaud jrobichaud deleted the update-versions branch March 29, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants