-
Notifications
You must be signed in to change notification settings - Fork 473
Set all the python/django version numbers correctly #863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #863 +/- ##
=======================================
Coverage 87.42% 87.42%
=======================================
Files 32 32
Lines 954 954
Branches 76 76
=======================================
Hits 834 834
Misses 102 102
Partials 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| fail-fast: false | ||
| matrix: # https://docs.djangoproject.com/en/stable/faq/install/#what-python-version-can-i-use-with-django | ||
| django-version: ["3.2", "4.2", "5.0", "5.1", "5.2rc1"] | ||
| django-version: ["4.2", "5.0", "5.1", "5.2rc1"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@auvipy Are you OK with dropping Python 3.8 and Django v3.2 support?
Would this fail if we had "5.2" instead of "5.2rc1"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the moment yes.
Co-authored-by: Christian Clauss <[email protected]>
|
@cclauss when django 5.2 will be officially out we will be able to change 5.2rc1 to 5.2. Pre-releases have to be exact matches. |
Co-authored-by: Christian Clauss <[email protected]>
|
In a few days we will be able to make a new PR replacing |
| tox -- --cov=django_celery_beat --cov-report=xml --no-cov-on-fail --cov-report term | ||
| else | ||
| tox |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I see... I usually run these with tox -e py as mentioned at https://docs.github.com/en/actions/use-cases-and-examples/building-and-testing/building-and-testing-python#running-tests-with-tox which gives that flexibility. Without -e py things have to be hard coded.
auvipy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im going to hold this
|
@auvipy , on hold like waiting for django 5.2 to release? If so, I will just replace the |
auvipy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed by #865
we tend to keep bit older versions supported to make the transition easier for legacy projects. thanks for you efforts though. the CI was not fully synced so I have to take care of them. |
Uh oh!
There was an error while loading. Please reload this page.