Skip to content

Set all the python/django version numbers correctly #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jrobichaud wants to merge 8 commits into from
Closed

Set all the python/django version numbers correctly #863

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8e4827a
Attempt to set all the version numbers correctly everywhere
jrobichaud Mar 27, 2025
68ef60f
Remove django 3.2 from the test matrix
jrobichaud Mar 27, 2025
ff5fa84
Clean tox matrix
jrobichaud Mar 27, 2025
954eb02
Fix ruff version
jrobichaud Mar 27, 2025
acc84a0
Update test.yml
jrobichaud Mar 28, 2025
0cce4dd
Add missing pypy bumps to 3.11
jrobichaud Mar 28, 2025
3955e10
Update .readthedocs.yaml
jrobichaud Mar 28, 2025
8152b1b
Fix wrong latest version according to readthedocs documentation
jrobichaud Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,9 @@ jobs:
strategy:
fail-fast: false
matrix: # https://docs.djangoproject.com/en/stable/faq/install/#what-python-version-can-i-use-with-django
django-version: ["3.2", "4.2", "5.0", "5.1", "5.2rc1"]
django-version: ["4.2", "5.0", "5.1", "5.2rc1"]
Copy link
Contributor

@cclauss cclauss Mar 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@auvipy Are you OK with dropping Python 3.8 and Django v3.2 support?

Would this fail if we had "5.2" instead of "5.2rc1"?

Copy link
Contributor Author

@jrobichaud jrobichaud Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the moment yes.

python-version: ['3.9', '3.10', '3.11', '3.12', '3.13', 'pypy-3.10']
exclude:
- django-version: "3.2"
python-version: "3.11"
- django-version: "3.2"
python-version: "3.12"
- django-version: "3.2"
python-version: "3.13"
- django-version: "4.2"
python-version: "3.13"
- django-version: "5.0"
Expand Down
2 changes: 1 addition & 1 deletion .readthedocs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ version: 2
build:
os: ubuntu-20.04
tools:
python: "3.8"
python: "3.12"
sphinx:
configuration: docs/conf.py
python:
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[tool.ruff]
target-version = "py38"
target-version = "py39"

lint.select = [
"A", # flake8-builtins
Expand Down
7 changes: 3 additions & 4 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,19 +16,18 @@
License :: OSI Approved :: BSD License
Programming Language :: Python
Programming Language :: Python :: 3
Programming Language :: Python :: 3.8
Programming Language :: Python :: 3.9
Programming Language :: Python :: 3.10
Programming Language :: Python :: 3.11
Programming Language :: Python :: 3.12
Programming Language :: Python :: 3.13
Programming Language :: Python :: Implementation :: CPython
Programming Language :: Python :: Implementation :: PyPy
Framework :: Django
Framework :: Django :: 3.2
Framework :: Django :: 4.1
Framework :: Django :: 4.2
Framework :: Django :: 5.0
Framework :: Django :: 5.1
Framework :: Django :: 5.2
Operating System :: OS Independent
Topic :: Communications
Topic :: System :: Distributed Computing
Expand Down Expand Up @@ -116,7 +115,7 @@ def reqs(*f):
url=meta['homepage'],
platforms=['any'],
license='BSD',
python_requires='>=3.8',
python_requires='>=3.9',
install_requires=reqs('default.txt') + reqs('runtime.txt'),
classifiers=classifiers,
entry_points={
Expand Down
27 changes: 13 additions & 14 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,29 +2,28 @@

[gh-actions]
python =
3.8: py38, apicheck, linkcheck
3.9: py39, flake8, pydocstyle, cov
3.9: py39, flake8, pydocstyle, cov, apicheck, linkcheck
3.10: py310
3.11: py311
3.12: py312
3.13: py313
pypy-3.10: pypy3

[gh-actions:env]
DJANGO =
3.2: django32
4.1: django41
4.2: django42
5.0: django50
5.1: django51
5.2rc1: django52

[tox]
envlist =
py38-django{32,42}
py39-django{32,42}
py310-django{32,42,50,51}
py311-django{42,50,51}
py312-django{42,50,51}
pypy3-django{32,42,50,51}
py39-django{42}
py310-django{42,50,51,52}
py311-django{42,50,51,52}
py312-django{42,50,51,52}
py313-django{51,52}
pypy3-django{42,50,51,52}
flake8
apicheck
linkcheck
Expand All @@ -39,11 +38,11 @@ deps=

cov: -r{toxinidir}/requirements/test-django.txt

django32: Django ~= 3.2
django41: Django ~= 4.1
django42: Django ~= 4.2
django50: Django ~= 5.0
django51: Django ~= 5.1rc1
django51: Django ~= 5.1
django52: Django ~= 5.2rc1

linkcheck,apicheck: -r{toxinidir}/requirements/docs.txt
flake8,pydocstyle: -r{toxinidir}/requirements/pkgutils.txt
Expand All @@ -55,12 +54,12 @@ commands =


[testenv:apicheck]
basepython = python3.8
basepython = python3.9
commands =
sphinx-build -W -b apicheck -d {envtmpdir}/doctrees docs docs/_build/apicheck

[testenv:linkcheck]
basepython = python3.8
basepython = python3.9
commands =
sphinx-build -W -b linkcheck -d {envtmpdir}/doctrees docs docs/_build/linkcheck

Expand Down