Merge pull request #60 from cgarciagarcia/bugfix/improve-filter-action

fix: remove empty filter value

Author: cgarciagarcia

src/actions/filter.ts

@@ -23,6 +23,18 @@ export const filterAction = <Al>(
   state: GlobalState<Al>,
   override: boolean | FilterValue = false,
 ): GlobalState<Al> => {
+  value = Array.isArray(value)
+    ? value.filter((val) => `${val}`.length !== 0)
+    : value;
+
+  const isEmpty = Array.isArray(value)
+    ? value.length === 0
+    : `${value}`.length === 0;
+
+  if (isEmpty) {
+    return removeFilterAction([attribute], state);
+  }
+
   const conflicts = state.pruneConflictingFilters[attribute];
   const allFilters = state.filters.filter(
     (filter) =>

tests/Units/filterAction.test.ts

@@ -353,4 +353,42 @@ describe("Filter Action test: ", () => {
       },
     ]);
   });
+
+  it("should remove filter in case filter value is empty string", () => {
+    const state: GlobalState = {
+      ...initialState,
+      filters: [
+        {
+          attribute: "name",
+          value: ["Carlos"],
+        },
+      ],
+    } as const;
+
+    const result = filterAction("name", ["", "", ""], state);
+
+    expect(result.filters).toEqual([]);
+  });
+
+  it("should remove only empty filters", () => {
+    const state: GlobalState = {
+      ...initialState,
+      filters: [
+        {
+          attribute: "name",
+          value: ["Carlos"],
+        },
+      ],
+    } as const;
+
+    const result = filterAction("name", ["", "eduardo"], state);
+
+    expect(result.filters).toEqual([
+      {
+        attribute: "name",
+        value: ["Carlos", "eduardo"],
+        operator: undefined,
+      },
+    ]);
+  });
 });