allow spaces in $CHROME_PATH

gsouf · gsouf · commit d525ff9b1693 · 2018-04-26T11:07:23.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -22,10 +22,10 @@
     
 * Features:
   * Improved startup error message
+* Bug fixes:
   * Fixed bugs on shutdown
   * Fixed unit tests
-* Bug fixes:
-  * none
+  * Allow CHROME_PATH to have spaces in the path
   
 --------------
 
diff --git a/src/BrowserFactory.php b/src/BrowserFactory.php
@@ -21,7 +21,7 @@ public function __construct(string $chromeBinaries = null)
             $envChromePath = getenv('CHROME_PATH');
 
             if ($envChromePath) {
-                $chromeBinaries = $envChromePath;
+                $chromeBinaries = '"' . $envChromePath . '"';
             } else {
                 $chromeBinaries = 'chrome';
             }

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ public function __construct(string $chromeBinaries = null)`
`21`	`21`	`$envChromePath = getenv('CHROME_PATH');`
`22`	`22`
`23`	`23`	`if ($envChromePath) {`
`24`		`- $chromeBinaries = $envChromePath;`
	`24`	`+ $chromeBinaries = '"' . $envChromePath . '"';`
`25`	`25`	`} else {`
`26`	`26`	`$chromeBinaries = 'chrome';`
`27`	`27`	`}`