Skip to content

Commit 9629216

Browse files
committed
Fix comments, change block-start/end.
1 parent 307f041 commit 9629216

File tree

2 files changed

+19
-27
lines changed

2 files changed

+19
-27
lines changed

packages/ckeditor5-list/theme/listformatting.css

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,24 +10,22 @@
1010
}
1111

1212
.ck-content li {
13-
/* Our opiniotanted styling in the lists, it prevents
14-
* the shift of content when a list is turned into a multi-block one
15-
* (enter + backspace scenario).
13+
/* Opinionated list content styling: prevents content shift
14+
* when a list becomes multi-block (Enter + Backspace scenario).
1615
* See: https://github.com/ckeditor/ckeditor5/pull/18801
1716
*/
1817
& > p:first-of-type {
19-
margin-block-start: 0;
18+
margin-top: 0;
2019
}
2120

22-
/* Rule which prevents the margins to appear when a
23-
* bogus paragraph gets a line height or text alignment.
24-
* We use only-of-type as the cell may have a div with column resize.
25-
* to provide more consistent experience with the first one.
21+
/* Prevents margins from appearing when a bogus paragraph
22+
* receives line height or text alignment.
23+
* Ensures a consistent experience with the first paragraph.
2624
* See: https://github.com/ckeditor/ckeditor5/pull/18801
2725
*/
2826
& > p:only-child {
29-
margin-block-start: 0;
30-
margin-block-end: 0;
27+
margin-top: 0;
28+
margin-bottom: 0;
3129
}
3230

3331
&.ck-list-marker-bold::marker {

packages/ckeditor5-table/theme/table.css

Lines changed: 11 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -54,31 +54,25 @@
5454

5555
& > td,
5656
& > th {
57-
/* Our opiniotanted styling in the tables, it prevents
58-
* the shift of content when the enter is pressed at the top.
57+
/* Opinionated table content styling: prevents content from shifting
58+
* when Enter is pressed in the first cell.
5959
* See: https://github.com/ckeditor/ckeditor5/pull/18801
6060
*/
6161
& > p:first-of-type {
62-
margin-block-start: 0;
62+
margin-top: 0;
6363
}
6464

65-
/* Symmetrical to the above rule which styles the last paragraph
66-
* to provide more consistent experience with the first one.
65+
/* Mirrors the rule above for the last paragraph to keep the
66+
* experience consistent with the first paragraph.
67+
*
68+
* Together, these rules prevent margins from appearing when a
69+
* bogus paragraph becomes a real paragraph after it receives line
70+
* height, text alignment, or other block style.
71+
*
6772
* See: https://github.com/ckeditor/ckeditor5/pull/18801
6873
*/
6974
& > p:last-of-type {
70-
margin-block-end: 0;
71-
}
72-
73-
/* Rule which prevents the margins to appear when a
74-
* bogus paragraph gets a line height or text alingment.
75-
* We use only-of-type as the cell may have a div with column resize.
76-
* to provide more consistent experience with the first one.
77-
* See: https://github.com/ckeditor/ckeditor5/pull/18801
78-
*/
79-
& > p:only-of-type {
80-
margin-block-start: 0;
81-
margin-block-end: 0;
75+
margin-bottom: 0;
8276
}
8377

8478
min-width: 2em;

0 commit comments

Comments
 (0)