feat(api): impl From<Cow<'static, str>> for Id,OsStr, Str

Author: germangarces

clap_builder/src/builder/os_str.rs

@@ -128,6 +128,16 @@ impl From<&'_ &'static str> for OsStr {
     }
 }
 
+#[cfg(feature = "string")]
+impl From<Cow<'static, str>> for OsStr {
+    fn from(cow: Cow<'static, str>) -> Self {
+        match cow {
+            Cow::Borrowed(s) => Self::from(s),
+            Cow::Owned(s) => Self::from(s),
+        }
+    }
+}
+
 impl From<OsStr> for std::ffi::OsString {
     fn from(name: OsStr) -> Self {
         name.name.into_os_string()
@@ -351,4 +361,4 @@ mod tests {
         let osstr = OsStr::from(cow);
         assert_eq!(osstr, OsStr::from("world"));
     }
-}
+}

clap_builder/src/builder/str.rs

@@ -77,6 +77,16 @@ impl From<&'_ &'static str> for Str {
     }
 }
 
+#[cfg(feature = "string")]
+impl From<Cow<'static, str>> for Str {
+    fn from(cow: Cow<'static, str>) -> Self {
+        match cow {
+            Cow::Borrowed(s) => Self::from(s),
+            Cow::Owned(s) => Self::from(s),
+        }
+    }
+}
+
 impl From<Str> for String {
     fn from(name: Str) -> Self {
         name.name.into_string()
@@ -316,7 +326,6 @@ impl std::hash::Hash for Inner {
     }
 }
 
-
 #[cfg(test)]
 #[cfg(feature = "string")]
 mod tests {

clap_builder/src/builder/styled_str.rs

@@ -186,6 +186,15 @@ impl From<&'_ &'static str> for StyledStr {
     }
 }
 
+impl From<Cow<'static, str>> for StyledStr {
+    fn from(cow: Cow<'static, str>) -> Self {
+        match cow {
+            Cow::Borrowed(s) => StyledStr::from(s),
+            Cow::Owned(s) => StyledStr::from(s),
+        }
+    }
+}
+
 impl std::fmt::Write for StyledStr {
     #[inline]
     fn write_str(&mut self, s: &str) -> Result<(), std::fmt::Error> {
@@ -271,4 +280,4 @@ mod tests {
         let styled = StyledStr::from(cow);
         assert_eq!(styled, StyledStr::from("world"));
     }
-}
+}

clap_builder/src/util/id.rs

@@ -79,6 +79,13 @@ impl From<Id> for Str {
     }
 }
 
+#[cfg(feature = "string")]
+impl From<Cow<'static, str>> for Id {
+    fn from(name: Cow<'static, str>) -> Self {
+        Self(name.into())
+    }
+}
+
 impl From<Id> for String {
     fn from(name: Id) -> Self {
         Str::from(name).into()