fix: accept 'required' fields [#285] #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slightfoot
requested changes
Oct 14, 2025
| bool isOn(dynamic on) => on == 'on'; | ||
| /// [true] if a value is ['on'] or ['required'], else [false]. For JsonSerializable | ||
| /// For required fields it considered as 'on' | ||
| bool isOn(dynamic on) => on == 'on' || on == 'required'; |
Collaborator
There was a problem hiding this comment.
change variable name from on to value
* feat: improve test framework [#281] * fix: make name change test more sensible [#281] * fix: obfuscate identifiers better and more often [#281] # Conflicts: # packages/clerk_auth/test/integration/clerk_api/environment_test.dart # packages/clerk_auth/test/integration/clerk_api/sign_in_test.dart # packages/clerk_auth/test/integration/clerk_api/sign_up_test.dart # packages/clerk_auth/test/integration/clerk_api/user_details_test.dart # packages/clerk_auth/test/integration/clerk_auth/sign_in_test.dart # packages/clerk_auth/test/integration/clerk_auth/sign_up_test.dart # packages/clerk_auth/test/test_helpers.dart
* Fix required field does not update when call updateUser Required fields currently not updating when call updateUser in clerk_auth * Create json_serialization_helpers_test.dart
shinyford
force-pushed
the
fix/285-accept-required-fields
branch
from
0bc9e99 to
584127d
Compare
slightfoot
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #285