chore(clerk-js,types): Clean up deprecated attribute (#6788)

Author: mauricioabreu

.changeset/seven-buses-teach.md

@@ -0,0 +1,6 @@
+---
+'@clerk/clerk-js': minor
+'@clerk/types': minor
+---
+
+[Billing Beta] Remove deprecated `subscription` attribute from Billing

packages/clerk-js/src/core/resources/CommercePayment.ts

@@ -19,10 +19,6 @@ export class CommercePayment extends BaseResource implements CommercePaymentReso
   paidAt?: Date;
   updatedAt!: Date;
   paymentSource!: CommercePaymentSourceResource;
-  /**
-   * @deprecated
-   */
-  subscription!: CommerceSubscriptionItemResource;
   subscriptionItem!: CommerceSubscriptionItemResource;
   chargeType!: CommercePaymentChargeType;
   status!: CommercePaymentStatus;
@@ -43,7 +39,6 @@ export class CommercePayment extends BaseResource implements CommercePaymentReso
     this.failedAt = data.failed_at ? unixEpochToDate(data.failed_at) : undefined;
     this.updatedAt = unixEpochToDate(data.updated_at);
     this.paymentSource = new CommercePaymentSource(data.payment_source);
-    this.subscription = new CommerceSubscriptionItem(data.subscription);
     this.subscriptionItem = new CommerceSubscriptionItem(data.subscription_item);
     this.chargeType = data.charge_type;
     this.status = data.status;

packages/types/src/commerce.ts

@@ -645,16 +645,6 @@ export interface CommercePaymentResource extends ClerkResource {
    * ```
    */
   paymentSource: CommercePaymentSourceResource;
-  /**
-   * @deprecated Use `subscriptionItem` instead.
-   * @experimental This is an experimental API for the Billing feature that is available under a public beta, and the API is subject to change.
-   * It is advised to pin the SDK version and the clerk-js version to a specific version to avoid breaking changes.
-   * @example
-   * ```tsx
-   * <ClerkProvider clerkJsVersion="x.x.x" />
-   * ```
-   */
-  subscription: CommerceSubscriptionItemResource;
   /**
    * @experimental This is an experimental API for the Billing feature that is available under a public beta, and the API is subject to change.
    * It is advised to pin the SDK version and the clerk-js version to a specific version to avoid breaking changes.