Drop stdio.h include #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sha1.c file includes stdio.h without seemingly using it for anyhing. It doesn't make sense for a hash library to use stdio and having that header included makes it harder to use the library in freestanding environment. Drop the include to make it easier to use the library in freestanding projects.
There was a problem hiding this comment.
Pull Request Overview
This pull request removes an unused stdio.h include from the SHA1 hash library implementation to improve compatibility with freestanding environments where standard I/O functionality is not available.
- Removes the stdio.h include directive that was not being used by the hash library
- Improves library usability in embedded/freestanding environments where stdio is unavailable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sha1.c file includes stdio.h without seemingly using it for anyhing. It doesn't make sense for a hash library to use stdio and having that header included makes it harder to use the library in freestanding environment.
Drop the include to make it easier to use the library in freestanding projects.
Closes #13