cljs.collection-test passing

- Set needs to assoc value to underlying hashmap
- Set needs to return the value in the underlying hashmap
- skip a transient test we just don't support at the moment
- run the collections test
- :nodejs target for lite-test, easier to flip to :simple

Author: swannodette

resources/lite_test.edn

@@ -9,6 +9,7 @@
  :npm-deps         {:lodash "4.17.4"}
  :closure-warnings {:non-standard-jsdoc :off :global-this :off}
  :install-deps     true
+ :target           :nodejs
  :language-out     :es5
  :foreign-libs
  [{:file "src/test/cljs/calculator_global.js"

src/main/cljs/cljs/core.cljs

@@ -12991,7 +12991,7 @@ reduces them without incurring seq initialization"
 
   ICollection
   (-conj [coll o]
-    (Set. meta (assoc hash-map o nil) nil))
+    (Set. meta (assoc hash-map o o) nil))
 
   IEmptyableCollection
   (-empty [coll] (with-meta (. Set -EMPTY) meta))
@@ -13025,7 +13025,7 @@ reduces them without incurring seq initialization"
     (-lookup coll v nil))
   (-lookup [coll v not-found]
     (if (-contains-key? hash-map v)
-      v
+      (-lookup hash-map v)
       not-found))
 
   ISet

src/test/cljs/cljs/collections_test.cljs

@@ -1127,9 +1127,12 @@
               (next (chunk-cons (chunk b) nil))))))
 
 (deftest test-cljs-3124
-  (let [t (assoc! (transient []) 0 1)]
-    (persistent! t)
-    (is (= :fail (try (get t :a :not-found) (catch js/Error e :fail))))))
+  ;; Doesn't work under :lite-mode because there are not
+  ;; separate transient types for now
+  (when-not ^boolean LITE_MODE
+    (let [t (assoc! (transient []) 0 1)]
+      (persistent! t)
+      (is (= :fail (try (get t :a :not-found) (catch js/Error e :fail)))))))
 
 (deftest test-cljs-3317
   (testing "persistent vector invoke matches clojure"

src/test/cljs/lite_test_runner.cljs

@@ -14,7 +14,7 @@
             [cljs.new-new-test]
             [cljs.printing-test]
             [cljs.seqs-test]
-            ;; [cljs.collections-test]
+            [cljs.collections-test]
             [cljs.hashing-test]
             [cljs.core-test]
             ;; [cljs.chunked-seq] ;; doesn't exist in :lite-mode
@@ -78,6 +78,7 @@
   'cljs.printing-test
   'cljs.new-new-test
   'cljs.seqs-test
+  'cljs.collections-test
   'cljs.hashing-test
   'cljs.core-test
   'cljs.interop-test ;; ES6 stuff