Skip to content

Commit e0ef800

Browse files
committed
CP-6: Allow to use it out of a container
1 parent 3062223 commit e0ef800

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

connect/eaas/helpers.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import inspect
77
import os
88
import subprocess
9+
from uuid import uuid4
910

1011
import pkg_resources
1112

@@ -23,7 +24,7 @@ def get_container_id():
2324
try:
2425
result.check_returncode()
2526
except subprocess.CalledProcessError:
26-
raise EaaSError(result.stderr.decode())
27+
return str(uuid4())
2728

2829
_, container_id = result.stdout.decode()[:-1].rsplit('/', 1)
2930
return container_id

tests/test_helpers.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,17 +36,19 @@ def test_get_container_id_ko(mocker):
3636
)
3737
result.stderr = 'error message'.encode('utf-8')
3838
mocker.patch('connect.eaas.helpers.subprocess.run', return_value=result)
39-
with pytest.raises(EaaSError) as cv:
40-
get_container_id()
39+
expected_result = get_container_id()
4140

42-
assert str(cv.value) == 'error message'
41+
assert isinstance(expected_result, str)
42+
assert len(expected_result) > 0
4343

4444

4545
def test_get_environment_with_defaults(mocker):
4646
os.environ['API_KEY'] = 'SU-000:XXXX'
4747
os.environ['ENVIRONMENT_ID'] = 'ENV-0000-0000-01'
4848
if 'SERVER_ADDRESS' in os.environ:
4949
del os.environ['SERVER_ADDRESS']
50+
if 'INSTANCE_ID' in os.environ:
51+
del os.environ['INSTANCE_ID']
5052
mocker.patch('connect.eaas.helpers.get_container_id', return_value='container_id')
5153
env = get_environment()
5254
assert env['api_key'] == 'SU-000:XXXX'

0 commit comments

Comments
 (0)