Merge pull request #45 from cloudblue/LITE-22276-Add-default-filter-in-Get-New-Cases

LITE-22276 Add default filter and set to 10 records to show

Author: marcserrat

lib/connect/api/caseRequests/actions.js

@@ -27,7 +27,7 @@ const CASE_COMMENTS_FILTERS_MAP = {
 };
 
 const searchCases = async (client, data) => {
-  const limit = data.records_per_page || 100;
+  const limit = data.records_per_page || 10;
   let offset = 0;
   let results = [];
   let response = [];

lib/fields/input/search_cases.js

@@ -16,21 +16,6 @@ const FILTER_FIELDS = {
       list: false,
     },
   },
-  status: {
-    default: {
-      key: 'state',
-      label: 'Case Status',
-      helpText: 'Using this filter only cases matching the requested status will be available for the Zap.',
-      required: false,
-      choices: {
-        pending: 'Pending',
-        inquiring: 'Inquiring',
-        resolved: 'Resolved',
-        closed: 'Closed',
-      },
-      list: false,
-    },
-  },
   priority: {
     default: {
       key: 'priority',
@@ -104,13 +89,24 @@ async function getFilterFields(z, bundle) {
 }
 
 module.exports = [
+  {
+    key: 'state',
+    label: 'Case Status',
+    helpText: 'Using this filter only cases matching the requested status will be available for the Zap.',
+    required: true,
+    choices: {
+      pending: 'Pending',
+      inquiring: 'Inquiring',
+      resolved: 'Resolved',
+      closed: 'Closed',
+    },
+  },
   {
     key: 'filters',
     label: 'Additional filters',
     type: 'string',
     choices: {
       id: 'Case ID',
-      status: 'Case Status',
       priority: 'Priority',
       from_account: 'From Acccount',
       from_actor: 'From Actor',

lib/triggers/caseRequest/new_case.js

@@ -29,7 +29,7 @@ module.exports = {
           + 'this option is especially useful in the case you are creating a Zap for an account either with a lot '
           + 'of requests or to limit the amount of samples obtained while designing the zap.',
         type: 'integer',
-        default: '100',
+        default: '10',
         required: false,
       },
     ]),

package.json

@@ -1,6 +1,6 @@
 {
   "name": "connect-fulfillment-zapier-app",
-  "version": "24.0.0",
+  "version": "24.0.1",
   "description": "A Zapier App to automate Cloud Blue Connect Fulfillment workflows.",
   "repository": {
     "type": "git",

tests/specs/connect/api/caseRequests/actions.spec.js

@@ -43,7 +43,7 @@ describe('caseRequests.actions', () => {
         $le: '2019-12-05T09:11:22.000Z'
       },
       offset: 0,
-      limit: 100,
+      limit: 10,
     });
   });
 
@@ -57,7 +57,7 @@ describe('caseRequests.actions', () => {
     await searchCases(client, data);
     expect(mockedFn).toHaveBeenCalledWith({
       offset: 0,
-      limit: 100,
+      limit: 10,
     });
   });  
 

tests/specs/fields/input/searchCases.spec.js

@@ -25,19 +25,6 @@ describe('search cases', () => {
     const fn = _.filter(inputFields, (item) => typeof item === 'function')[0];
     const fields = await fn(null, bundle);
     expect(fields).toEqual([
-      { 
-        key: 'state',
-        required: false,
-        label: 'Case Status',
-        helpText: 'Using this filter only cases matching the requested status will be available for the Zap.',
-        list: false,
-        choices: {
-                'closed':'Closed',
-                'inquiring':'Inquiring',
-                'pending':'Pending',
-                'resolved':'Resolved',
-        }
-      },
       { 
         key: 'priority',
         label: 'Using this filter only cases matching the requested Priority will be available for the Zap.',