Skip to content

Commit 2dccd38

Browse files
Catch generic Exception on dispatch and do Skip.
1 parent a9031ba commit 2dccd38

File tree

2 files changed

+16
-0
lines changed

2 files changed

+16
-0
lines changed

connect/resources/fulfillment_automation.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,14 @@ def dispatch(self, request):
9797
self._update_conversation_if_exists(conversation, request.id, skip)
9898
return skip.code
9999

100+
except NotImplementedError:
101+
raise
102+
103+
except Exception as ex:
104+
logger.warning('Skipping request {} because an exception was raised: {}'
105+
.format(request.id, ex))
106+
return ''
107+
100108
@deprecated(deprecated_in='16.0', details='Use ``TierConfig.get`` instead.')
101109
def get_tier_config(self, tier_id, product_id):
102110
"""

connect/resources/tier_config_automation.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,14 @@ def dispatch(self, request):
6767
except SkipRequest as skip:
6868
return skip.code
6969

70+
except NotImplementedError:
71+
raise
72+
73+
except Exception as ex:
74+
logger.warning('Skipping request {} because an exception was raised: {}'
75+
.format(request.id, ex))
76+
return ''
77+
7078
return ''
7179

7280
@function_log

0 commit comments

Comments
 (0)