Skip to content

Commit 5628a9a

Browse files
Comments begin with a capital letter, as per PEP-8
1 parent 0795a6e commit 5628a9a

File tree

3 files changed

+17
-17
lines changed

3 files changed

+17
-17
lines changed

README.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ class ExampleRequestProcessor(FulfillmentAutomation):
4848

4949
logger.info('Processing request {}'.format(request.id))
5050

51-
# custom logic
51+
# Custom logic
5252
if request.type == 'purchase':
5353
for item in request.asset.items:
5454
if item.quantity > 100000:
@@ -60,22 +60,22 @@ class ExampleRequestProcessor(FulfillmentAutomation):
6060
param.value_error = 'Email address has not been provided, please provide one'
6161
raise FulfillmentInquire(params=[param])
6262

63-
# approve by ActivationTile
63+
# Approve by ActivationTile
6464
return ActivationTileResponse('\n # Welcome to Fallball!\n\nYes, '
6565
'you decided to have an account in our amazing service!')
66-
# or
66+
# Or
6767
# return TemplateResource().render(pk='TEMPLATE_ID', request_id=request.id)
6868

69-
# approve by Template
69+
# Approve by Template
7070
return ActivationTemplateResponse(template_id="TL-497-535-242")
71-
# or
71+
# Or
7272
# return TemplateResource().get(pk='TEMPLATE_ID')
7373

7474
elif request.type == 'change':
75-
# fail
75+
# Fail
7676
raise FulfillmentFail()
7777
else:
78-
# skip request
78+
# Skip request
7979
raise Skip()
8080

8181

connect/config.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,15 +37,15 @@ def __init__(
3737
# Load config from file name
3838
if filename:
3939
if not os.path.exists(filename):
40-
raise IOError('Not file `{}` on directory'.format(filename))
40+
raise IOError('No filename `{}` on directory'.format(filename))
4141

4242
with open(filename) as config_file:
4343
configs = config_file.read()
4444

4545
try:
4646
configs = json.loads(configs)
4747
except Exception as ex:
48-
raise TypeError('Invalid config file `{}`\n'
48+
raise TypeError('Invalid config filename `{}`\n'
4949
'ERROR: {}'.format(filename, str(ex)))
5050

5151
(api_url, api_key, products) = (configs.get('apiEndpoint', ''),

example/example.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
from connect.models import ActivationTemplateResponse, ActivationTileResponse
1212
from connect.models.exception import FulfillmentFail, FulfillmentInquire, Skip
1313

14-
# set logger level / default level ERROR
14+
# Set logger level / default level ERROR
1515
logger.setLevel("DEBUG")
1616

1717
# If we remove this line, it is done implicitly
@@ -23,7 +23,7 @@ def process_request(self, request):
2323

2424
logger.info('Processing request {}'.format(request.id))
2525

26-
# custom logic
26+
# Custom logic
2727
if request.type == 'purchase':
2828
for item in request.asset.items:
2929
if item.quantity > 100000:
@@ -35,23 +35,23 @@ def process_request(self, request):
3535
param.value_error = 'Email address has not been provided, please provide one'
3636
raise FulfillmentInquire(params=[param])
3737

38-
# approve by ActivationTile
38+
# Approve by ActivationTile
3939
return ActivationTileResponse('\n # Welcome to Fallball!\n\nYes, you decided '
4040
'to have an account in our amazing service!')
41-
# or
41+
# Or
4242
# return TemplateResource().render(pk='TEMPLATE_ID', request_id=request.id)
4343

44-
# approve by Template
44+
# Approve by Template
4545
# noinspection PyUnreachableCode
4646
return ActivationTemplateResponse(template_id="TL-497-535-242")
47-
# or
47+
# Or
4848
# return TemplateResource().get(pk='TEMPLATE_ID')
4949

5050
elif request.type == 'change':
51-
# fail
51+
# Fail
5252
raise FulfillmentFail()
5353
else:
54-
# skip request
54+
# Skip request
5555
raise Skip()
5656

5757

0 commit comments

Comments
 (0)