Refactored Asset.get_parameter_by_id and Asset.get_item_by_id

Author: JaviCerveraIngram

connect/models/asset.py

@@ -15,17 +15,11 @@
 
 
 class Asset(BaseModel):
-    def get_parameter_by_id(self, id_):
-        try:
-            return [a for a in self.params if a.id == id_][0]
-        except IndexError:
-            return None
-
-    def get_item_by_id(self, id_):
-        try:
-            return [a for a in self.items if a.id == id_][0]
-        except IndexError:
-            return None
+    def get_parameter_by_id(self, identity):
+        return self._get_by_id(self.params, identity)
+
+    def get_item_by_id(self, identity):
+        return self._get_by_id(self.items, identity)
 
 
 class AssetSchema(BaseSchema):

connect/models/base.py

@@ -15,6 +15,13 @@ def __init__(self, *args, **kwargs):
             for attr, val in kwargs.items():
                 setattr(self, attr, val)
 
+    @staticmethod
+    def _get_by_id(objects, identity):
+        try:
+            return filter(lambda obj: obj.id == identity, objects)[0]
+        except IndexError:
+            return None
+
 
 class BaseSchema(Schema):
     id = fields.Str()