Improving tests

Author: martinconstante

tests/test_asset_request.py

@@ -3,11 +3,12 @@
 # Copyright (c) 2019-2020 Ingram Micro. All Rights Reserved.
 
 import os
+import pytest
 import unittest
 from mock import patch
 from connect.resources.asset_request import AssetRequestResource
 from connect.config import Config
-from .common import Response, load_str
+from .common import load_str
 
 update_param_asset_request_response = load_str(
     os.path.join(os.path.dirname(__file__), 'data', 'update_param_asset_request_response.json'))
@@ -17,19 +18,33 @@ class TestAssetRequest(unittest.TestCase):
     def setUp(self):
         self.config = Config(file='tests/config.json')
 
-    @patch('requests.post')
-    def update_param_asset_request(self, post_mock):
-        post_mock.return_value = Response(True, update_param_asset_request_response, 200)
+    @patch('requests.put')
+    def test_update_param_asset_request(self, put_mock):
         request = AssetRequestResource(config=self.config)
         pr_id = 'PR-4405-9454-9305-001'
-        asset_request = request(pr_id)
-        assert post_mock.call_count == 1
-        post_mock.assert_called_with(
+        test_data = {
+            "params": [{
+                "id": "PM-9861-7949-8492-0001",
+                "value": "32323323"
+            }]
+        }
+        request.update_param_asset_request(pr_id, test_data, "i'm a note!")
+        assert put_mock.call_count == 1
+        put_mock.assert_called_with(
             headers={'Content-Type': 'application/json', 'Authorization': 'ApiKey XXXX:YYYYY'},
             timeout=300,
             url=('http://localhost:8080/api/public/v1/'
-                 'tier/requests/PR-4405-9454-9305-001'))
-        assert asset_request.id == 'PR-4405-9454-9305-001'
+                 'requests/PR-4405-9454-9305-001/'),
+            json={
+                'asset': test_data,
+                'note': "i'm a note!",
+            })
+
+    def test_invalid_request_id(self):
+        asset_request = AssetRequestResource(config=self.config)
+        with pytest.raises(ValueError) as e:
+            asset_request.update_param_asset_request(None, None, None)
+        assert str(e.value) == 'Invalid ID'
 
 
 if __name__ == "__main__":

tests/test_billing_request.py

@@ -5,12 +5,13 @@
 
 import os
 import unittest
+import pytest
 
 from mock import Mock, call, patch
 
 from connect.config import Config
 from connect.models import BillingRequest
-from connect.resources.subscription import BillingRequestResource
+from connect.resources.billing_request import BillingRequestResource
 
 from .common import Response, load_json, load_str
 
@@ -103,7 +104,6 @@ def test_add_billing_request(self, post_mock):
             json=body,
             timeout=300,
             url='http://localhost:8080/api/public/v1/subscriptions/requests')
-
         assert isinstance(billing_request, BillingRequest)
         assert billing_request.id == 'BRP-6750-9514-7931-0001'
 
@@ -115,17 +115,21 @@ def test_modify_billing_request(self, put_mock):
         pk = 'BRP-6750-9514-7931-0001'
         request = BillingRequestResource(config=self.config)
         billing_request = request.update_billing_request(pk, body)
-        print(billing_request)
         url = ('http://localhost:8080/api/public/v1'
                '/subscriptions/requests/BRP-6750-9514-7931-0001/attributes')
         put_mock.assert_called_with(
             headers={'Content-Type': 'application/json', 'Authorization': 'ApiKey XXXX:YYYYY'},
             json=body,
             timeout=300,
             url=url)
-
         assert billing_request == ({'provider': {'external_id': '321-123'}}, 200)
 
+    def test_update_billing_request_bad(self):
+        request = BillingRequestResource(config=self.config)
+        with pytest.raises(ValueError) as e:
+            request.update_billing_request(None, None)
+        assert str(e.value) == 'Invalid ID'
+
 
 if __name__ == "__main__":
     unittest.main()

tests/test_directory.py

@@ -11,7 +11,7 @@
 import pytest
 
 from connect.exceptions import ServerError
-from connect.models import Asset, Product, TierConfig
+from connect.models import Asset, Product, TierConfig, TierAccount
 from connect.resources import Directory
 from .common import Response, load_str
 
@@ -152,3 +152,15 @@ def test_get_tier_config(get_mock):
 def test_get_tier_config_bad():
     with pytest.raises(ServerError):
         Directory().get_tier_config('TC-000-000-000')
+
+
+@patch('requests.get', MagicMock(return_value=_get_bad_response()))
+def test_search_tier_account_bad():
+    with pytest.raises(ServerError):
+        Directory().search_tier_accounts(None)
+
+
+@patch('requests.get', MagicMock(return_value=_get_bad_response()))
+def test_get_tier_account_bad():
+    with pytest.raises(ServerError):
+        Directory().get_tier_account('TAR-0000-0000-0000-000-000')

tests/test_subscriptions.py

@@ -0,0 +1,49 @@
+# -*- coding: utf-8 -*-
+
+# This file is part of the Ingram Micro Cloud Blue Connect SDK.
+# Copyright (c) 2019-2020 Ingram Micro. All Rights Reserved.
+
+import os
+import unittest
+
+from mock import Mock, patch
+
+from connect.config import Config
+from connect.resources.subscription import Subscription
+from connect.models import BillingRequest
+from .common import Response, load_json, load_str
+
+add_billing_request_body = load_json(
+    os.path.join(os.path.dirname(__file__), 'data', 'add_billing_request.json'))
+add_billing_request_response = load_str(
+    os.path.join(os.path.dirname(__file__), 'data', 'response_add_billing_request.json'))
+
+
+class testSubscriptions(unittest.TestCase):
+
+    def setUp(self):
+        self.config = Config(file='tests/config.json')
+
+    @patch('requests.post')
+    def test_create_billing_request(self, post_mock):
+        # type: (Mock) -> None
+        post_mock.return_value = Response(True, add_billing_request_response, 200)
+        body = add_billing_request_body
+        request = Subscription(config=self.config)
+        billing_request = request.create_billing_request(body)
+        assert isinstance(billing_request, BillingRequest)
+        assert billing_request.id == 'BRP-6750-9514-7931-0001'
+
+    @patch('requests.put')
+    def test_update_billing_request(self, put_mock):
+        update_billing_request_response = {'provider': {'external_id': '321-123'}}
+        put_mock.return_value = Response(True, update_billing_request_response, 200)
+        body = update_billing_request_response
+        pk = 'BRP-6750-9514-7931-0001'
+        request = Subscription(config=self.config)
+        billing_request = request.update_billing_request(pk, body)
+        assert billing_request == ({'provider': {'external_id': '321-123'}}, 200)
+
+
+if __name__ == "__main__":
+    unittest.main()

tests/test_template.py

@@ -8,6 +8,7 @@
 import pytest
 
 from connect.exceptions import ServerError
+from connect.models.activation_tile_response import ActivationTileResponse
 from connect.resources import TemplateResource
 from .common import Response, load_str
 
@@ -70,3 +71,28 @@ def test_get_template(get_mock):
     template = TemplateResource().get('TL-313-655-502')
     assert template.template_id == 'TL-313-655-502'
 
+
+def test_render_bad():
+    template_resource = TemplateResource()
+    with pytest.raises(ValueError) as e:
+        template_resource.render(None, None)
+        assert str(e.value) == 'Invalid ids for render template'
+
+
+@patch('requests.get')
+def test_renders(get_mock):
+    get_mock.return_value = Response(
+        ok=True,
+        text='# Sample Activation Template',
+        status_code=200,
+    )
+    template_resource = TemplateResource()
+    response = template_resource.render('TL-313-655-502', 'PR-845-746-468')
+    assert isinstance(response, ActivationTileResponse)
+    assert response.tile == '# Sample Activation Template'
+
+    get_mock.assert_called_with(
+        url='http://localhost:8080/api/public/v1/templates/TL-313-655-502/render',
+        params={'request_id': 'PR-845-746-468'},
+        headers={'Content-Type': 'application/json', 'Authorization': 'ApiKey XXXX:YYYYY'},
+        timeout=300)

tests/test_tier_config_request.py

@@ -5,6 +5,7 @@
 
 import os
 import unittest
+import pytest
 
 from mock import call, patch
 
@@ -167,6 +168,41 @@ def test_fail_tier_account_request(self, post_mock):
                  'tier/config-requests/TAR-6458-9737-0065-004-001/fail'))
         assert tier_config_request == ('', 204)
 
+    def test_fail_tar_pend(self):
+        request = TierConfigRequestResource()
+        with pytest.raises(ValueError) as e:
+            request.pend(None)
+        assert str(e.value) == 'Invalid ID'
+
+    def test_fail_tar_inquire(self):
+        request = TierConfigRequestResource()
+        with pytest.raises(ValueError) as e:
+            request.inquire(None)
+        assert str(e.value) == 'Invalid ID'
+
+    def test_fail_tar_approve(self):
+        request = TierConfigRequestResource()
+        with pytest.raises(ValueError) as e:
+            request.approve(None, None)
+        assert str(e.value) == 'Invalid ID'
+
+    def test_fail_tar_fail(self):
+        request = TierConfigRequestResource()
+        with pytest.raises(ValueError) as e:
+            request.fail(None, None)
+        assert str(e.value) == 'Invalid ID'
+
+    def test_fail_tar_assign(self):
+        request = TierConfigRequestResource()
+        with pytest.raises(ValueError) as e:
+            request.assign(None)
+        assert str(e.value) == 'Invalid ID'
+
+    def test_fail_tar_unassign(self):
+        request = TierConfigRequestResource()
+        with pytest.raises(ValueError) as e:
+            request.unassign(None)
+        assert str(e.value) == 'Invalid ID'
 
 if __name__ == "__main__":
     unittest.main()